Bug #47394: Unnecessary requirement for \Image implementation in ImageService and ImageVariant - TYPO3.Media - TYPO3 Forge

Base Distribution TYPO3.Form TYPO3.Imagine TYPO3.Media TYPO3.Neos TYPO3.Neos.NodeTypes TYPO3.Party TYPO3.Setup TYPO3.SiteKickstarter TYPO3.Twitter.Bootstrap TYPO3.TYPO3CR TYPO3.TypoScript Coordination Group Website and Communication

Bug #47394

Unnecessary requirement for \Image implementation in ImageService and ImageVariant

Added by Thomas Hempel over 2 years ago. Updated almost 2 years ago.

Status:

Resolved

Start date:

2013-04-20

Priority:

Should have

Due date:

Assigned To:

Adrian Föder

% Done:

100%

Category:

Target version:

Description

Hi,

when implementing the ImageInterface, you probably do that to use the viewhelpers from Media package. Due to a little oddity, this doesn't work right now. The constructor of the ImageVariant requires a concrete implementation of
\TYPO3\Media\Domain\Model\Image and so does the transformImage method in the ImageService.

This makes it pretty much impossible to have your own image model without duplicating almost the entire media package.

As far as I can oversee it, this can be fixed pretty easily by setting the required type to the interface instead of the implementation. I've attached a patch that does that.

ImageInterface_patch.diff (2 kB) Thomas Hempel, 2013-04-20 11:25

Associated revisions

Revision 1f896fc3
Added by Adrian Föder almost 2 years ago

[TASK] Replace tight Image coupling with ImageInterface

This replaces occurrences of unnecessary tight Image type hints with
the more loose ImageInterface.

Besides, some minor code beautifications are made.

Resolves: #47394
Change-Id: I787a4ac70752bb70820787efba76bd6005da140a
Reviewed-on: https://review.typo3.org/20041
Reviewed-by: Karsten Dambekalns
Tested-by: Karsten Dambekalns
Tested-by: Adrian Föder
Reviewed-by: Aske Ertmann
Reviewed-by: Mattias Nilsson
Reviewed-by: Adrian Föder