Bug #47510
Content editing is broken when page uses RequireJS
Status: | Resolved | Start date: | 2013-04-23 | |
---|---|---|---|---|
Priority: | Should have | Due date: | ||
Assigned To: | - | % Done: | 100% |
|
Category: | JavaScript | |||
Target version: | Base Distribution - 1.0 beta 1 |
Description
When the website that should be edited uses RequireJS, the Neos backend breaks (i.e. the top menu is shown, but no content can be edited. Even basic functionality is missing. When disabling the local RequireJS instance, everything works fine.
I suppose this is because the script mentioned in the data-main attribute of the RequireJS script tag is not executed - but I have not further debugged this issue.
Maybe it's possible to totally separate the JS Neos uses by using the separation techniques RequireJS provides (see http://requirejs.org/docs/api.html#multiversion).
Related issues
Associated revisions
[BUGFIX] Neos backend breaks if the frontend uses requirejs
When the frontend of a website is using requirejs the backend of
Neos does not load, or the content editing does not work. This change
puts all Neos requirejs configuration in the 'neos' context and
wraps requirejs to prevent a double declaration of requirejs.
It also changes the way requirejs is included as the data-main
attribute will not work if requirejs is already defined in the
frontend.
Change-Id: I166593bd6d53a24b4f65e29c2622a4a9f437d2d7
Fixes: #47510
Fixes: #48074
Fixes: #53883
Releases: master
Reviewed-on: https://review.typo3.org/26487
Reviewed-by: Rens Admiraal
Tested-by: Rens Admiraal
Reviewed-by: Robert Lemke
History
#1 Updated by Aske Ertmann about 2 years ago
- Target version set to 1.0 beta 1
#2 Updated by Gerrit Code Review over 1 year ago
- Status changed from New to Under Review
Patch set 5 for branch master of project Packages/TYPO3.Neos has been pushed to the review server.
It is available at https://review.typo3.org/26487
#3 Updated by Gerrit Code Review over 1 year ago
Patch set 6 for branch master of project Packages/TYPO3.Neos has been pushed to the review server.
It is available at https://review.typo3.org/26487
#4 Updated by Gerrit Code Review over 1 year ago
Patch set 7 for branch master of project Packages/TYPO3.Neos has been pushed to the review server.
It is available at https://review.typo3.org/26487
#5 Updated by Rens Admiraal over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 856803b48053815be74706044477cbae6f850e27.