Bug #47575
header element is rendered in lib.stdheader for all cases
| Status: | Resolved | Start date: | 2013-04-25 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Patrick Broens | % Done: | 100% |
|
| Category: | Content Rendering | Spent time: | - | |
| Target version: | 6.2.0 | |||
| TYPO3 Version: | 6.2 | Is Regression: | ||
| PHP Version: | Sprint Focus: | |||
| Complexity: |
Description
According to the HTML5 spec the header element represents
a group of introductory or navigational aids. A header element typically contains the section’s heading (an h1–h6 element or an hgroup element), but can also contain other content, such as a table of contents, a search form, or any relevant logos.
First of all, the hgroup element has been removed from the specs.
Secondly, header is used to group elements. Currently the header element is used if there is any content in lib.stdheader, so for instance with a single hx. This is not desired because a single element is not a group.
Wrapping lib.stdheader with the header element should only occur when the date is added to the header.
Related issues
Associated revisions
[BUGFIX] header element is rendered in lib.stdheader in all HTML5 cases
According to the HTML5 specs the header element should be used for
grouping elements. Currently the header element is used if there is any
content in lib.stdheader, for instance a single hx.
This patch fixes this by wrapping lib.stdheader with the header element
only when the date is added to the header. Otherwise it will use the
default div wrapping.
Change-Id: I3e1335e1b1d64962a8488b8177d72eb1126e89dd
Fixes: #47575
Releases: 6.2
Reviewed-on: https://review.typo3.org/20149
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
History
#1 Updated by Gerrit Code Review over 2 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20149
#2 Updated by Mathias Brodala about 2 years ago
Another issue which arises from the current structure: one cannot use header content elements within header and footer areas on the page.
#3 Updated by Ernesto Baschny almost 2 years ago
The hgroup has been removed already in https://review.typo3.org/20147 (for 6.2.0alpha1).
#4 Updated by Gerrit Code Review almost 2 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20149
#5 Updated by Patrick Broens almost 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 7fb894c55566deddaec96523454567e6cb0a5ed0.