Media Management

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20432

Is it with this change posible to query an aditional mm relation that are added to the tca?

For a client project I need to extent sys_file/asset with the posibility to add tags. So I need to implement a new mm relation.
I see the patch is wip, what needs to be done or is still missing? Maybe I can help.

If you plan to change the api, please do it now. Don't wait to long.

When do you want to release a first version?

Hi Frans,

Is it with this change posible to query an aditional mm relation that are added to the tca?

That is the goal / idea, indeed.

I see the patch is wip, what needs to be done or is still missing? Maybe I can help.

It is basically finished. Though, I wanted to add some unit tests making sure the "mm" query would work and since I haven't really tested I am expecting some amendment to the patch. Here an example for Categories but could also work for Tags as long you have TCA configured.

         /** @var $match \TYPO3\CMS\Media\QueryElement\Match */
         $match = $this->objectManager->get('TYPO3\CMS\Media\QueryElement\Match');
         $match->addMatch('categories', $uidOrObject);
         $match->addMatch('categories', $uidOrObject2);

         /** @var $assetRepository \TYPO3\CMS\Media\Domain\Model\AssetRepository */
         $assetRepository = $this->objectManager->get('TYPO3\CMS\Media\Domain\Model\AssetRepository');
         $assetRepository->findBy($match);

The same should work for findByCategories - or findByTags from your example:

         /** @var $assetRepository \TYPO3\CMS\Media\Domain\Model\AssetRepository */
         $assetRepository = $this->objectManager->get('TYPO3\CMS\Media\Domain\Model\AssetRepository');
         $assetRepository->findByCategories($uidOrObject);

It is a "difficult" patch to get into but if you have time helping / making sure the feature is there, it would be awesome. I could merge the others patches if it helps apply the change set easier. Let me know.

When do you want to release a first version?

The soonest as possible. I think we have a decent set of features making it usable for a daily life use. However, before doing so, I would like merging the remaining patches pending in Gerrit as well as this critical one.

I wil have a look at it monday.

The critical patch I reviewed and tested already now hope a core dev has a look at it. For the others I wil make some time monday or you must 100% be sure they are ok :)

Actually, if you would like to have another MM relation than categories working for the findBy method (see example above) you probably have to change a few things. The current implementation is a special case for categories but should not be too difficult to extend.

In EXT:media/Classes/QueryElement/Query.php, consider updating getClauseCategories to getClauseMM and around line 205 replace the if (! empty($matches['categories'])) by

        $matches = $this->match->getMatches();
        foreach ($this->match->getMatches() as $field => $value) {
            if ($this->tcaFieldService->hasRelationManyToMany($field)) {
                // here the rest with some modification...
            }
        }

A last thing: there is a bit of confusion with method naming with getClauseCategories, getClauseSearch, getClauseConstraints which all have the same purpose. Don't worry, I will rename them. There are private methods anyway.

Oke, will look into that.

Maybe you can help me on an other thing. What's the easiest/best way to preform a LIKE query on the asset repository?

I need something like:

SELECT * FROM..... Where sys_file.identifier LIKE '/sample_data_map/%'

Not tested code:

         /** @var $match \TYPO3\CMS\Media\QueryElement\Match */
         $match = $this->objectManager->get('TYPO3\CMS\Media\QueryElement\Match');
         $match->setSearchTerm('foo');

         /** @var $assetRepository \TYPO3\CMS\Media\Domain\Model\AssetRepository */
         $assetRepository = $this->objectManager->get('TYPO3\CMS\Media\Domain\Model\AssetRepository');
         $assetRepository->findBy($match);

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20432

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20432