Feature #47919

Catch exceptions in USER TS objects

Added by Philipp Gampe over 2 years ago. Updated 9 months ago.

Status:Resolved Start date:2013-05-04
Priority:Should have Due date:
Assigned To:Philipp Gampe % Done:

100%
Category:Frontend Spent time: -
Target version:-
PHP Version:5.4 Sprint Focus:
Complexity:easy

Description

Currently exceptions break the complete site. This is very bad, because it makes the debugging process much harder.

Catch exceptions (if possible) and convert them into nice error messages for the user.

Related issues

related to Core - Bug #61861: Frontend throws exception on missing image New 2014-09-24
precedes Core - Bug #63811: Undefined $exception variable in ContentObjectRenderer::c... Resolved 2014-12-12

Associated revisions

Revision e1ef2c63
Added by Helmut Hummel 9 months ago

[FEATURE] Add possibility to catch exception during rendering

Currently exceptions throw when rendering single
content objects bubble up to the default exception
handler and break the complete frontend.

This change adds the possibility to register an exception handler
for a content object which can render an appropriate
message instead if wanted (e.g. in production context).

Releases: master
Resolves: #47919
Change-Id: I9e3697401432b043e164fa84340739a525f80264
Reviewed-on: http://review.typo3.org/31123
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

History

#1 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20494

#2 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20494

#3 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20494

#4 Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20494

#5 Updated by Gerrit Code Review about 2 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20494

#6 Updated by Philipp Gampe about 2 years ago

I use the following assumptions:
  • If debug is enabled, show backtrace
  • BE users should see an error message
  • Error messages must not be cached (no_cache)
  • Visitors should see nothing (empty string as return value)

#7 Updated by Gerrit Code Review about 2 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20494

#8 Updated by Ingo Renner about 2 years ago

Philipp Gampe wrote:

I use the following assumptions:

[...]

sounds very good!

#9 Updated by Ernesto Baschny almost 2 years ago

  • Target version deleted (6.2.0)

#10 Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31123

#11 Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31123

#12 Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31123

#13 Updated by Gerrit Code Review 11 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31123

#14 Updated by Gerrit Code Review 11 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31123

#15 Updated by Gerrit Code Review 11 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31123

#16 Updated by Gerrit Code Review 11 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31123

#17 Updated by Gerrit Code Review 10 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31123

#18 Updated by Gerrit Code Review 9 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31123

#19 Updated by Gerrit Code Review 9 months ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31123

#20 Updated by Gerrit Code Review 9 months ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31123

#21 Updated by Gerrit Code Review 9 months ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31123

#22 Updated by Gerrit Code Review 9 months ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31123

#23 Updated by Gerrit Code Review 9 months ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31123

#24 Updated by Gerrit Code Review 9 months ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31123

#25 Updated by Gerrit Code Review 9 months ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31123

#26 Updated by Gerrit Code Review 9 months ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31123

#27 Updated by Helmut Hummel 9 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF