Bug #47988
Colon not possible in TCA "displayCond" value
| Status: | Resolved | Start date: | 2013-05-06 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | - | % Done: | 100% |
|
| Category: | FormEngine aka TCEforms | Spent time: | - | |
| Target version: | - | |||
| TYPO3 Version: | 4.5 | Is Regression: | ||
| PHP Version: | Sprint Focus: | |||
| Complexity: | easy |
Description
Currently a colon is not possible in the value of a display condition for TCA fields.
So something like this would does work:
FIELD:view.templateRootPath:=:EXT:myext/Resources/Private/Templates/customTemplateFolder/
The funtion "isDisplayCondition" explodes the string by the ":" character. So the example string is exploded into 5 parts but the 5th part is ignored.
The "explode" should be limited to 4 parts and 4th part should contain the whole string after the third colon.
Related issues
Associated revisions
[BUGFIX] Allow colon in last "displayCond" part
Explode the "displayCond"-string just to required
number of parts. So the last part can also contain colons.
Also backports unit-tests from ElementConditionMatcher of
TYPO3 6.1 and adds a check for this colon-bugfix here.
Resolves: #47988
Releases: 6.0, 4.7, 4.5
Change-Id: I940e17ea346dda91607573406fd83d919d83e36a
Reviewed-on: https://review.typo3.org/20552
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
History
#1 Updated by Gerrit Code Review about 2 years ago
- Status changed from New to Under Review
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/20551
#2 Updated by Thorsten Kahler about 2 years ago
Sascha Egerer wrote:
The "explode" should be limited to 4 parts and 4th part should contain the whole string after the third colon.
I'd even prefer to explode only into 2 parts and split the second part according to the case (FIELD, EXT, REC, ...).
#3 Updated by Gerrit Code Review about 2 years ago
Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/20552
#4 Updated by Gerrit Code Review about 2 years ago
Patch set 2 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/20552
#5 Updated by Gerrit Code Review about 2 years ago
Patch set 3 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/20552
#6 Updated by Gerrit Code Review about 2 years ago
Patch set 4 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/20552
#7 Updated by Anonymous about 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 7f42eca5563f16f7fc408d1bfa45eb532d109cef.