Feature #48218
Make NumberViewHelper regard locale like CurrencyViewHelper does.
| Status: | Resolved | Start date: | 2013-05-15 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Alexander Berl | % Done: | 100% |
|
| Category: | ViewHelpers | |||
| Target version: | - | |||
| Has patch: | No |
Description
Currently the NumberViewHelper doesn't regard the locale, but the CurrencyViewHelper (and DateViewHelper) does.
Those ViewHelpers should be put in line with each other regarding Locale awareness.
Associated revisions
[FEATURE] Make NumberViewHelper regard locale
This change makes the NumberViewHelper use the forceLocale attribute
like the Currency and DateViewHelper do.
It also abstracts the locale awareness away into a seperate abstract
ViewHelper class to lay a foundation for other such ViewHelpers.
Change-Id: Ib3c05586160a521e0bc380373296b85b09bb0872
Releases: master
Resolves: #48218
History
#1 Updated by Gerrit Code Review about 2 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20788
#2 Updated by Gerrit Code Review about 2 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20788
#3 Updated by Bastian Waidelich almost 2 years ago
- Tracker changed from Task to Feature
Alexander, thanks for your great support and please excuse the slow review process. I'll take care of this one now - but I think this should be declared "feature"
#4 Updated by Gerrit Code Review almost 2 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20788
#5 Updated by Alexander Berl almost 2 years ago
No problem Bastian, I'm pretty much out of Flow coding business for the time being either, so I can barely provide as much as a half year ago ;(
Thanks for taking care!
#6 Updated by Bastian Waidelich almost 2 years ago
Alexander Berl wrote:
No problem Bastian, I'm pretty much out of Flow coding business for the time being either, so I can barely provide as much as a half year ago ;(
Too bad, your patches were of great quality!
#7 Updated by Alexander Berl almost 2 years ago
I hope to get back in latest somewhen in spring. But then with a relatively big project where I will require quite some features and contribute them if they're not done yet ;)
I'll still keep watching and providing my input and the occasional weekend-patch till then.
#8 Updated by Bastian Waidelich almost 2 years ago
Alexander Berl wrote:
I hope to get back in latest somewhen in spring. But then with a relatively big project where I will require quite some features and contribute them if they're not done yet ;)
I'll still keep watching and providing my input and the occasional weekend-patch till then.
good to hear!
#9 Updated by Alexander Berl about 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset df00bf92a42d92b26e66c30976272115a24992f1.