Bug #48231
Ignoring of inheritance type in FlowAnnotationDriver no longer works
| Status: | Resolved | Start date: | 2013-05-16 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Karsten Dambekalns | % Done: | 100% |
|
| Category: | Persistence | |||
| Target version: | TYPO3 Flow Base Distribution - 2.0 | |||
| PHP Version: | Complexity: | |||
| Has patch: | No | Affected Flow version: | Flow 2.0.0 beta 2 |
Description
Due to weird circumstances the tests for the FlowAnnotationDriver were skipped for a while, and change Ie6e46efa858a651b2f1fe4b08d78039249504dea broke the functionality to disable inheritance of no subclasses exist for a class annotated with an InheritanceType annotation.
Associated revisions
[BUGFIX] Ignoring of inheritance type in FlowAnnotationDriver broken
Due to weird circumstances the tests for the FlowAnnotationDriver were
skipped for a while, and change Ie6e46efa858a651b2f1fe4b08d78039249504dea
broke the functionality to disable inheritance of no subclasses exist
for a class annotated with an InheritanceType annotation.
This changes fixes that.
Change-Id: I06387f1f38340c34ce3b52a4e09a3ff2081a8782
Fixes: #48231
Releases: master, 2.0
[BUGFIX] Broken inheritance type handling in FlowAnnotationDriver
This reverts commit 93fbe9fc8d789547f05eec2b4945eb6c565fa3fa because
it broke more than it was supposed to fix.
The failing test that led to the original "fix" was in fact broken and
is fixed with this change.
Change-Id: Iaaecffad1c10d7cfde310c67237cfcc96164e4cc
Related: #48231
Releases: master
History
#1 Updated by Gerrit Code Review about 2 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20817
#2 Updated by Gerrit Code Review about 2 years ago
Patch set 1 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/20970
#3 Updated by Karsten Dambekalns about 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 93fbe9fc8d789547f05eec2b4945eb6c565fa3fa.
#4 Updated by Marco Falkenberg about 2 years ago
After applying the changeset the persistence (load/update/create) of subclasses fails, if you use a repository to the corresponding abstract super class. Doctrine tries to persist all the properties of the super class for the table of the sub class.
#5 Updated by Karsten Dambekalns about 2 years ago
- Status changed from Resolved to Accepted
So this "fix" actually broke things. Sorry for that, a revert is on the way.
#6 Updated by Karsten Dambekalns almost 2 years ago
- Target version changed from 2.0 to 2.0.1
#7 Updated by Karsten Dambekalns almost 2 years ago
- Status changed from Accepted to Resolved
- Target version changed from 2.0.1 to 2.0