Bug #48261

Work Package #45020: Content Editing Stability and Features

Inline editable properties are reset after applying changes in the inspector for reloadIfChanged properties

Added by Pankaj Lele about 2 years ago. Updated 9 months ago.

Status:Closed Start date:2013-05-16
Priority:Must have Due date:
Assigned To:Aske Ertmann % Done:

100%
Category:UI
Target version:Base Distribution - 1.0 beta 1

Description

Inline editable poperties of content elements are reset to default values when some other "reloadIfChanged" properties are edited in the inspector.

To reproduce the behavior:

  1. create new Text with Image content
  2. don't do anything in content editing area
  3. change e.g. the "Title" field in the inspector
  4. click apply
  5. add some text in the content editing area now
  6. wait for changes to be auto-saved
  7. change "Title" again in inspector
  8. click apply
  9. you will see "Enter text here" again

Associated revisions

Revision 35c1407a
Added by Sebastian Kurfuerst almost 2 years ago

[BUGFIX] inline editables should preserve their content after applying changes in the inspector

Before this change, the following bug appeared:

  • you modified e.g. the text of the "Text" content element
  • then, for the same content element, you directly changed a property
    in the inspector (f.e. toggling "hidden")
  • then, press apply.
  • This has reset the contents of the "Text" content element back to
    the initial value; losing all content changes.

The bug was that the inspector stored all properties of the node,
and on apply, restored all of them. The bugfix is that the inspector
only updates properties that were changed and not all of them on
apply.

Change-Id: I57a8fe0c257bccd1b3a74b33b8b2d03bf37201ec
Resolves: #48261
Reviewed-on: https://review.typo3.org/24260
Reviewed-by: Sebastian Kurfuerst
Tested-by: Sebastian Kurfuerst

History

#1 Updated by Aske Ertmann about 2 years ago

  • Status changed from New to Accepted
  • Assigned To set to Aske Ertmann
  • Target version set to 1.0 beta 1

#2 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24260

#3 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24260

#4 Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24260

#5 Updated by Gerrit Code Review almost 2 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24260

#6 Updated by Gerrit Code Review almost 2 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24260

#7 Updated by Sebastian Kurfuerst almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8 Updated by Aske Ertmann 9 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF