Bug #48887
Support numeric identifiers in IdentityRoutePart
| Status: | Resolved | Start date: | 2013-06-05 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assigned To: | Bastian Waidelich | % Done: | 100% |
|
| Category: | MVC - Routing | |||
| Target version: | - | |||
| PHP Version: | Complexity: | |||
| Has patch: | No | Affected Flow version: | Git 2.0 |
Description
In \TYPO3\Flow\Mvc\Routing\ObjectPathMappingRepository::findOneByObjectTypeUriPatternAndIdentifier the identifier of an object is checked to be exactly of type string. This should be changed to check for simple types that can be coerced to a string. Basically we need to support numeric values additionally to strings here.
Related issues
Associated revisions
[BUGFIX] Support numeric identifiers in dynamic route parts
Currently the dynamic route part handler provided by Flow (namely
``DynamicRoutePart`` and ``IdentityRoutePart``) only support objects
with string identifiers.
With this change also numeric identifiers are supported, for example
for entities with a numeric auto_increment identifier.
Change-Id: I57da5820c38d08494937f011439c00b0fd6851a7
Fixes: #48887
Fixes: #58517
Releases: master, 2.3, 2.2
[BUGFIX] Support numeric identifiers in dynamic route parts
Currently the dynamic route part handler provided by Flow (namely
``DynamicRoutePart`` and ``IdentityRoutePart``) only support objects
with string identifiers.
With this change also numeric identifiers are supported, for example
for entities with a numeric auto_increment identifier.
Change-Id: I57da5820c38d08494937f011439c00b0fd6851a7
Fixes: #48887
Fixes: #58517
Releases: master, 2.3, 2.2
[BUGFIX] Support numeric identifiers in dynamic route parts
Currently the dynamic route part handler provided by Flow (namely
``DynamicRoutePart`` and ``IdentityRoutePart``) only support objects
with string identifiers.
With this change also numeric identifiers are supported, for example
for entities with a numeric auto_increment identifier.
Change-Id: I57da5820c38d08494937f011439c00b0fd6851a7
Fixes: #48887
Fixes: #58517
Releases: master, 2.3, 2.2
History
#1 Updated by Bastian Waidelich about 2 years ago
FYI: I'm currently tweaking the IdentityRoutePart handler to support following "features":
- Respect "toLowerCase" flag (#44521)
- Disable lookup table (for unique properties like Id or UUID)
- Proper transliteration (using I18N package)
But it probably won't make it into 2.0 any longer
#2 Updated by Bastian Waidelich about 1 year ago
- Status changed from New to Accepted
- Assigned To changed from Christopher Hlubek to Bastian Waidelich
I lost track of this one.. But I'm on it now
#3 Updated by Gerrit Code Review about 1 year ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at https://review.typo3.org/30116
#4 Updated by Gerrit Code Review about 1 year ago
Patch set 2 for branch master of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at https://review.typo3.org/30116
#5 Updated by Gerrit Code Review 6 months ago
Patch set 3 for branch master of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at http://review.typo3.org/30116
#6 Updated by Gerrit Code Review 6 months ago
Patch set 1 for branch 2.3 of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at http://review.typo3.org/36997
#7 Updated by Gerrit Code Review 6 months ago
Patch set 1 for branch 2.2 of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at http://review.typo3.org/36998
#8 Updated by Bastian Waidelich 6 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 4e698ac3d86195f87863a2d17759871b4b9990f2.
#9 Updated by Gerrit Code Review 4 months ago
- Status changed from Resolved to Under Review
Patch set 2 for branch 2.2 of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at http://review.typo3.org/36998
#10 Updated by Gerrit Code Review 3 months ago
Patch set 3 for branch 2.2 of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at http://review.typo3.org/36998
#11 Updated by Bastian Waidelich 3 months ago
- Status changed from Under Review to Resolved
Applied in changeset 8687bfb8c34fe4a50febff3f968152decd98aaa3.