Bug #49
Fix comments and clean up code in phpCR tests
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assigned To: | Karsten Dambekalns | % Done: | 0% |
|
| Category: | - | |||
| Target version: | - | Estimated time: | 0.00 hour |
Description
Most of the comments in the phpCR_* tests still have HTML code or are just taken from the Jackrabbit tests ("Accessing jcr:uuid .... caused an ValueFormatException" should be "... phpCRValueFormatException").
In general, the code layout is not completely clean (which we should strive for) and the code smells a bit like too many comments.
If you use comments, please add an extra tab before the "//" sign so they are indented above the code line they comment.
History
#1 Updated by Karsten Dambekalns over 7 years ago
- Status changed from New to Accepted
Those tests are currently not used, the tests for the actual CR implementation are in the TYPO3CR package. They are still in SVN for reference use but will be cleaned up eventually...
#2 Updated by Karsten Dambekalns over 7 years ago
Some additions from #83:
- test case class names don't comply with the naming rules: phpCR_SomeTest instead of T3_phpCR_SomeTest
- @package annotations are mostly wrong, referring to phpCRJackrabbit
- some test methods are static
- some methods are not documented / lack doc comments
In general, some tests look more like functional tests than like unit tests - but I might be wrong with that.
#3 Updated by Karsten Dambekalns about 7 years ago
- Status changed from Accepted to Closed
- Estimated time set to 0.00
The tests have been removed from the package completely (pure interfaces are not suited for unit testing).
#4 Updated by Robert Lemke about 7 years ago
- Target version deleted (
1)