Bug #49458
Task #49162: Rewrite install tool
SystemEnvironmentCheck fails with undefined function imageftbbox
Status: | Resolved | Start date: | 2013-06-26 | |
---|---|---|---|---|
Priority: | Must have | Due date: | ||
Assigned To: | - | % Done: | 100% |
|
Category: | Install Tool | Spent time: | - | |
Target version: | 6.2.0 | |||
TYPO3 Version: | 6.2 | Is Regression: | ||
PHP Version: | 5.5 | Sprint Focus: | ||
Complexity: |
Description
Running the environment check without having the function imageftbbox enabled an Exception occurs that is even suppressed by using @imageftbbox. Therefore the whole page is just white.
Removing the @, the following Exception is shown:
Fatal error: Call to undefined function TYPO3\CMS\Install\SystemEnvironment\imageftbbox() in /vagrant/src/typo3_src/typo3/sysext/install/Classes/SystemEnvironment/Check.php on line 1073
A solution would be to check if the method is available via function_exists.
I could also provide a patch but I am unsure about the message that should be displayed to the user.
Related issues
Associated revisions
[BUGFIX] Check for imageftbbox() existence before usage
Install tool system environment check calls imageftbbox() without
checking if the function exists and may fatal. The patch adds a
function_exists() and introduces an error status message.
Resolves: #49458
Releases: 6.2
Change-Id: Ibb3be59d6506632db18d68e3394fd5a4b048da81
Reviewed-on: https://review.typo3.org/21783
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
History
#1 Updated by Christian Kuhn about 2 years ago
- Parent task set to #49162
#2 Updated by Christian Kuhn about 2 years ago
yes, should be fixed. check with method_exists first and return errorStatus if method is not there.
#3 Updated by Gerrit Code Review about 2 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21783
#4 Updated by Gerrit Code Review about 2 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21783
#5 Updated by Christian Kuhn about 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 4602db17be14bcd4c2a5dcfdcc5da3cb202f2650.