Bug #50395

Route cache caches routes for non dispatchable requests

Added by Marco Falkenberg about 2 years ago. Updated almost 2 years ago.

Status:Accepted Start date:2013-07-24
Priority:Should have Due date:
Assigned To:Bastian Waidelich % Done:

0%
Category:MVC - Routing
Target version:-
PHP Version: Complexity:
Has patch:No Affected Flow version:Git master

Description

The route cache caches all routes, even if the dispatchers cannot find the proper controller or action. On the one hand, that leads to a messy caching directory, if someone calls unavailable routes repeatedly. On the other the cached routes "block" potential identity routes, which occurs in my case.

Assume the the following routes configuration:

-
  uriPattern: 'users/{user}'
  defaults:
    '@controller':   'User'
    '@action':       'index'
  routeParts:
    'user':
      objectType: 'MyPackage\Model\User'
      uriPattern: '{name}'

# Fallback route
-
  uriPattern: '{@controller}/{@action}(.{@format})'
  defaults:
    '@format':  'html'

If you now call /users/horst and the user horst is not present for now, the fallback routes resolves the request with controller users and action horst and a caching entry is made. The dispatcher then throws the appropriate exception and a 404 shows up.

If you then create horst and call the url again, the 404 shows up (again), because the cached fallback route is used.

History

#1 Updated by Bastian Waidelich almost 2 years ago

  • Status changed from New to Needs Feedback

The routing cache kicks in as soon as a route matches/resolves successfully. As the routing is (kind of) decoupled from the MVC dispatching, I don't know how to solve this otherwise..
In general I would consider it bad practice to have to use a fallback route with {@controller} placeholder.. This comes with Flow in order to get started quickly, but usually you want to explicitly configure the routes for supported controllers of your app.
But even then the problem is the same with {@action}.. Do you have a suggestion on how to solve this?

#2 Updated by Marco Falkenberg almost 2 years ago

Mmmm... certainly the decoupled setting is well-choosen by design and so i have to deal with this drawback. Maybe i choose to replace the fallback route and in case of the users i define some routes like this: (What do you think?)


-
  uriPattern: 'user/new'
  defaults:
    '@controller':   'User'
    '@action':       'new'

-
  uriPattern: 'user'
  defaults:
    '@controller':   'User'
    '@action':       'index'

-
  uriPattern: 'users/{user}(/{@action})'
  defaults:
    '@controller':   'User'
    '@action':       'show'
  routeParts:
    'user':
      objectType: 'MyPackage\Model\User'
      uriPattern: '{name}'

#3 Updated by Bastian Waidelich almost 2 years ago

  • Status changed from Needs Feedback to Accepted
  • Assigned To set to Bastian Waidelich

Hi Marco,
thanks for your feedback.

We're currently working on automatic redirect-support for routes that might partially solve your problem.

I thought about the issue again during the weekend and maybe there is a solution..:
If we don't persist the cache directly but on __sleep() we could intercept that in the 404 handling.. I'll give this a shot asap.

#4 Updated by Marco Falkenberg almost 2 years ago

Hi Bastian.

Sounds good to me. Thanks for your infos!

Cheers

Also available in: Atom PDF