Bug #50568

Make FileExtensionFilter case insensitive

Added by Alexander Stehlik about 2 years ago. Updated almost 2 years ago.

Status:Resolved Start date:2013-07-30
Priority:Must have Due date:
Assigned To:- % Done:

100%
Category:FormEngine aka TCEforms Spent time: -
Target version:6.2.0
TYPO3 Version:6.2 Is Regression:
PHP Version: Sprint Focus:
Complexity:

Description

At the moment the \TYPO3\CMS\Core\Resource\Filter\FileExtensionFilter will not find any files if the allowed extensions are uppercase and the files in the directory have lowercase extensions.

This is a real problem because the \TYPO3\CMS\Backend\Form\FormEngin::getSingleField_typeGroup() method converts all configured allowed extensions to uppercase.

Associated revisions

Revision 8c8bdfe0
Added by Alexander Stehlik almost 2 years ago

[BUGFIX] Ignore case in file extension filter

This patch makes the FileExtensionFilter case insensitive.

If the filter is configured to allow files with the ".EXT"
extension it will now also allow files with an ".ext"
extension.

Additionally the order of a data provider method in the
FileExtensionFilterTest has been corrected.

Resolves: #50568
Releases: 6.2, 6.1, 6.0
Change-Id: I5761ab7f06116ef847caeb2ae786e580730c0e6b
Reviewed-on: https://review.typo3.org/22724
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Revision d7f01a29
Added by Alexander Stehlik almost 2 years ago

[BUGFIX] Ignore case in file extension filter

This patch makes the FileExtensionFilter case insensitive.

If the filter is configured to allow files with the ".EXT"
extension it will now also allow files with an ".ext"
extension.

Additionally the order of a data provider method in the
FileExtensionFilterTest has been corrected.

Resolves: #50568
Releases: 6.2, 6.1, 6.0
Change-Id: I5761ab7f06116ef847caeb2ae786e580730c0e6b
Reviewed-on: https://review.typo3.org/22937
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Revision 98bc16ba
Added by Alexander Stehlik almost 2 years ago

[BUGFIX] Ignore case in file extension filter

This patch makes the FileExtensionFilter case insensitive.

If the filter is configured to allow files with the ".EXT"
extension it will now also allow files with an ".ext"
extension.

Additionally the order of a data provider method in the
FileExtensionFilterTest has been corrected.

Resolves: #50568
Releases: 6.2, 6.1, 6.0
Change-Id: I5761ab7f06116ef847caeb2ae786e580730c0e6b
Reviewed-on: https://review.typo3.org/22938
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

History

#1 Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22724

#2 Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22724

#3 Updated by Gerrit Code Review about 2 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22724

#4 Updated by Gerrit Code Review about 2 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22724

#5 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/22937

#6 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/22938

#7 Updated by Alexander Stehlik almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF