TYPO3 Flow Base DistributionPackagesApplications

Feature #50657

rsync transfer method: add option the --exclude argument

Added by Tobias Liebig about 2 years ago. Updated about 1 year ago.

Status:Under Review Start date:2013-08-01
Priority:Should have Due date:
Assigned To:- % Done:

0%

Category:-
Target version:-

Description

add an exclude option for rsync task (--exclude arguments)

History

#1 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24306

#2 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24306

#3 Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24306

#4 Updated by Gerrit Code Review almost 2 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24306

#5 Updated by Andreas Dörler about 1 year ago

Hi,

this patch looks good to me. We're using something similar to exclude files and folders from rsync.

There is just one little thing, which should be changed imho:

$excludeFlags[] = '--exclude \'' . escapeshellarg($exclude) . '\'';

escapeshellarg automatically adds quotes, so there is no need for the extra \'

It'd be great to have this very useful patch integrated.

Kind regards
Andreas

#6 Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 5 for branch master of project Packages/TYPO3.Surf has been pushed to the review server.
It is available at https://review.typo3.org/24306

#7 Updated by Lars Malach about 1 year ago

Thanks Andreas for the hint.. I updated the patch..

Best, Lars

Also available in: Atom PDF