Feature #50801

Arguments "path" and "package" for f:layout View Helper

Added by Rafael Kähm almost 2 years ago. Updated almost 2 years ago.

Status:Closed Start date:2013-08-05
Priority:Could have Due date:
Assigned To:Bastian Waidelich % Done:

0%
Category:View
Target version:-
Has patch:No

Description

This is usefull if you use multiple packages for the same application.

Make sure you use "package" argument for each VH that needs this argument inside used layout, because Fluid does not know "origin" (also where layout come from) and tries to fetch controller and action from package, which uses this layout.

Also next step is to implement Node-"origin" functionality and after that Arguments "path" and "package" for f:render View Helper (for Partials).

gerrit review comes tomorrow.

History

#1 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22839

#2 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22839

#3 Updated by Bastian Waidelich almost 2 years ago

  • Status changed from Under Review to Needs Feedback

Thanks for the feature request and especially for the patch. But I'm afraid we won't need such feature once https://review.typo3.org/#/c/16392/ is merged

#4 Updated by Adrian Föder almost 2 years ago

Hi Bastian; how would you do that with the patch you've mentioned?

#5 Updated by Bastian Waidelich almost 2 years ago

Adrian Föder wrote:

Hi Bastian; how would you do that with the patch you've mentioned?

Create a Views.yaml and override the default layoutRootPath:

1    -
2      options:
3        layoutRootPath: 'resource://Some.Package/Private/Layouts'

If you only want to override it for certain packages/controllers/actions you can use the requestPattern configuration

#6 Updated by Rafael Kähm almost 2 years ago

Hi Bastian,

i see no opposites to using both patches for that. #50801 and #50826 are backward compatible to current Fluid and i think it is similarly compatible to #42176.

#7 Updated by Adrian Föder almost 2 years ago

Hi Bastian again,

but still with Views.yaml you can only set the path, not the complete "url" to the file.
Consider a use case where you have a Neos Site Package and a plain Flow package and you want to cross-reference concrete partial files, for example, just to avoid duplicate template code.

#8 Updated by Bastian Waidelich almost 2 years ago

Rafael Kähm wrote:

i see no opposites to using both patches for that.

The patches are compatible, yes. But we prefer a single way of configuration and I can't think of a scenario that is possible with this patch but not with the Views.yaml change

Adrian Föder wrote:

but still with Views.yaml you can only set the path, not the complete "url" to the file.

Of course:

1     -
2       requestFilter: 'isPackage("Original.Package") && isController("Foo") && isAction("bar")'
3       options:
4         partialPathAndFilenamePattern: 'resource://Some.Package/Private/Partials/Foo.html'

Or did I get you wrong?

I agree, setting "path"/"package" on the layout view helper is simpler for that use case. But with the views configuration we have one way of covering all sorts of scenarios.

#9 Updated by Adrian Föder almost 2 years ago

  • Status changed from Needs Feedback to On Hold
  • Priority changed from Must have to Could have

Bastian, for the mentioned configuration you will force-overwrite the whole partial path and file name (you even don't make it a "pattern" but a fixed value), so, different partials along the same Action request won't be possible, no?

1Hello <f:render partial="Party/NameAndIcon" />,
2here's your map: <f:render partial="Party/LocationMap" />

won't this always result into 'resource://Some.Package/Private/Partials/Foo.html' for both partials as configured in your example?

#10 Updated by Bastian Waidelich almost 2 years ago

Adrian Föder wrote:

Bastian, for the mentioned configuration you will force-overwrite the whole partial path and file name

Yes, you're right. This probably makes more sense with layouts. However with the "Fallback path" feature (#39870) it should be possible to do something like:

1     -
2       requestFilter: 'isPackage("Original.Package") && isController("Foo") && isAction("bar")'
3       options:
4         partialRootPaths: ['resource://Some.Package/Private/Partials/', 'resource://Original.Package/Private/Partials/']

I really don't want to be too restrictive and maybe I'm missing something, but I really fear Fluid getting too complex (code and usage-wise). Let's see what others think about this

#11 Updated by Bastian Waidelich almost 2 years ago

  • Status changed from On Hold to Closed
  • Assigned To set to Bastian Waidelich

Closing in favor of #42176 (as discussed via IRC)

Also available in: Atom PDF