Bug #51190
utf-8/multibyte characters break file list menu item
Status: | Resolved | Start date: | 2013-08-19 | |
---|---|---|---|---|
Priority: | Should have | Due date: | ||
Assigned To: | - | % Done: | 100% |
|
Category: | - | Spent time: | - | |
Target version: | - | |||
TYPO3 Version: | 6.2 | Is Regression: | ||
PHP Version: | Sprint Focus: | |||
Complexity: |
Description
Steps to reproduce¶
- Create a folder with some umlaut(special character) in your storage (example "Bärentatze")
- select the file list module and jump around your files and folders. this works pretty nice
- select folder "Bärentatze" or a folder underneath
- switch to some other random module (page, list, ...)
- select file list module again on the left
- <peng /> due to some escape/encoding issues the file list will report a failure on first access
Source of problem¶
In typo3/sysext/filelist/Classes/Controller/FileListController.php the following line will become part of the created inline Javascript(!):
if (top.fsMod) top.fsMod.recentIds["file"] = unescape("' . rawurlencode($this->id) . '");
unfortunatly unescape(javascript) will only work on ASCII but not on utf8. It even seems unecessary to decode the string at all, rawurlencode prepares the string in a way that can be consumed for usage as part of an url straight away.
Related issues
Associated revisions
[BUGFIX] utf8/multibyte character breaks menu filelist
Resolves: #51190
Releases: 6.2, 6.1
Change-Id: I105e23b12659495b4058edbc8091eee4374d58b9
[BUGFIX] utf8/multibyte character breaks menu filelist
Resolves: #51190
Releases: 6.2, 6.1
Change-Id: I105e23b12659495b4058edbc8091eee4374d58b9
Reviewed-on: https://review.typo3.org/23278
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
[BUGFIX] utf8/multibyte character breaks menu filelist
Resolves: #51190
Releases: 6.2, 6.1
Change-Id: I105e23b12659495b4058edbc8091eee4374d58b9
Reviewed-on: https://review.typo3.org/23378
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
History
#1 Updated by Gerrit Code Review almost 2 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23278
#2 Updated by Peter Niederlag almost 2 years ago
- TYPO3 Version changed from 6.1 to 6.2
#3 Updated by Anonymous almost 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset a3c653d8cbcad4b33a7a45bd48149b9e5d77e55e.
#4 Updated by Peter Niederlag almost 2 years ago
- Status changed from Resolved to Under Review
- % Done changed from 100 to 0
wrong status update by push in privat sandbox branch :(
The patch is still pending for +2
#5 Updated by Gerrit Code Review almost 2 years ago
Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/23378
#6 Updated by Anonymous almost 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset c1b09d6532536d347d0679b3ba6c4bd4764d56ff.
#7 Updated by Gerrit Code Review almost 2 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch master_new has been pushed to the review server.
It is available at https://review.typo3.org/23411
#8 Updated by Peter Niederlag almost 2 years ago
- Status changed from Under Review to Resolved
issue is fixed and merged to master(6.2) and 6.1