Bug #51396

Fix misleading method name

Added by Stefan Rotsch almost 2 years ago. Updated almost 2 years ago.

Status:Resolved Start date:2013-08-27
Priority:Should have Due date:
Assigned To:- % Done:

100%

Category:- Spent time: -
Target version:-
TYPO3 Version:6.2 Is Regression:
PHP Version: Sprint Focus:
Complexity:

Description

Purpose of the initialize() method in AbstractAction is the initialization of a handle, not the general initialization of an action. Thus, the method needs to be renamed to clearly indicate its purpose.


Related issues

related to Core - Task #49162: Rewrite install tool Resolved 2011-10-30

Associated revisions

Revision 95662d9e
Added by Stefan Rotsch almost 2 years ago

[TASK] Refactor misleading method name

Purpose of the initialize() method in the AbstractAction class is the
initialization of a handle. It is not intended to be used for generally
initializing classes derived from AbstractAction.

By refactoring the method name, the method's purpose will be indicated
more clearer.

Change-Id: I1603090e4dfccb5b57da4fa9c3792ec73647c524
Resolves: #51396
Releases: 6.2
Reviewed-on: https://review.typo3.org/23364
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

History

#1 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23364

#2 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23364

#3 Updated by Stefan Rotsch almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master_new has been pushed to the review server.
It is available at https://review.typo3.org/23401

#5 Updated by Wouter Wolters almost 2 years ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF