Bug #51433
Task #49162: Rewrite install tool
Install tool: Refactor database connect configuration settings
| Status: | Resolved | Start date: | 2013-08-28 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | - | % Done: | 100% |
|
| Category: | Install Tool | Spent time: | - | |
| Target version: | 6.2.0 | |||
| TYPO3 Version: | 6.2 | Is Regression: | ||
| PHP Version: | 5.4 | Sprint Focus: | ||
| Complexity: | medium |
Related issues
Associated revisions
[TASK] Install tool: Refactor db connect configuration settings
Refactor needsExecution() logic to make sure the mandatory settings
(username, password, host, port) are present in LocalConfiguration.php
before trying to establish a database connection using these settings.
This fixes a possible redirect loop if some of the mandatory settings
were not present, but the database connection check still succeeded.
Change-Id: Ifbf98a4bdcb62d9d29b7fbc1f3a03d3a7d621492
Resolves: #51433
Releases: 6.2
Reviewed-on: https://review.typo3.org/23394
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
History
#1 Updated by Gerrit Code Review almost 2 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23394
#2 Updated by Gerrit Code Review almost 2 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23394
#3 Updated by Gerrit Code Review almost 2 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23394
#4 Updated by Gerrit Code Review almost 2 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23394
#5 Updated by Gerrit Code Review almost 2 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23394
#6 Updated by Gerrit Code Review almost 2 years ago
Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23394
#7 Updated by Gerrit Code Review almost 2 years ago
Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23394
#8 Updated by Gerrit Code Review almost 2 years ago
Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23394
#9 Updated by Gerrit Code Review almost 2 years ago
Patch set 9 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23394
#10 Updated by Gerrit Code Review almost 2 years ago
Patch set 10 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23394
#11 Updated by Gerrit Code Review almost 2 years ago
Patch set 11 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23394
#12 Updated by Christian Kuhn almost 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 915d9987bbc7d9039273066c561a9fc6e6e5e6bf.