Task #51512

Epic #55070: Workpackages

Epic #54260: WP: FAL Missing Issues / Features / API

Story #54267: As an Editor I want to use a FAL withouth bugs

Unreadable directories cause exceptions

Added by Bernhard Kraft almost 2 years ago. Updated 8 months ago.

Status:Resolved Start date:2013-08-29
Priority:Should have Due date:
Assigned To:Steffen Ritter % Done:

100%
Category:File Abstraction Layer (FAL) Spent time: -
Target version:6.2.0
TYPO3 Version:6.2 Complexity:medium
PHP Version: Sprint Focus:

Description

If there is an unreadable file in the fileadmin directory the tree and listing frame of fileadmin throw execptions which make the fileadmin unusable.

reproducing the error:

mkdir -p fileadmin/testDirectory/someDirectory
chown root:root fileadmin/testDirectory/someDirectory
chmod 600 fileadmin/testDirectory/someDirectory

Browse to "testDirectory" and the issues begin ...

Normally all directoreis in "fileadmin" should be readable but in the case of a network mounted directory (Windows share, SMB/CIFS, NFS, cloud storage, etc.) it could be that parts of the fileadmin directory are unreadable and that this can not get changed by the webadmin.

I am working on a patch.

patch_51512.diff Magnifier (1019 Bytes) Bernhard Kraft, 2013-08-29 14:29

Related issues

related to Core - Bug #59568: filelist: No context-menu for folders Resolved 2014-06-13
duplicated by Core - Bug #53854: Exception if a directory in storage isn't readable Closed 2013-11-22

Associated revisions

Revision 017242ff
Added by Steffen Ritter over 1 year ago

[BUGFIX] Exception if directories are not readable

If a user has listing rights on a folder which contains
folders he does not have access to the user currently
will end up with Exceptions in folder trees, file lists
as well as element browsers.

Before FAL these folders just have been shown "locked".

This change introduces an "InaccessibleFolder" object
which will be created by the storage if a Folder is
requested which exists but there is no read access while
the user is allowed to list the contents of the parent
folder.

In addition the components have been adapted to use this
new information for a graceful behaviour.

WIP: Did not adapt the tests yet, since I need to do some
urgent customer work. Feel free to go on with that.

Resolves: #51512, #53854
Releases: 6.2
Change-Id: If5c234fe66d1930e4cc0cb16279d2f77874d82db
Reviewed-on: https://review.typo3.org/26905
Tested-by: Ingo Schmitt
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Ingo Schmitt
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

History

#1 Updated by Philipp Gampe almost 2 years ago

  • Category changed from Backend User Interface to File Abstraction Layer (FAL)
  • Status changed from New to Accepted
  • Assigned To set to Bernhard Kraft
  • Complexity set to medium

#2 Updated by Bernhard Kraft almost 2 years ago

#3 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23460

#4 Updated by Bernhard Kraft almost 2 years ago

  • Status changed from Under Review to Accepted

#5 Updated by Bernhard Kraft almost 2 years ago

The question is:

Should the drivers of a FAL storage throw execptions in the case of an error and those exceptions should get handled by the Repository/Storage.

Or should a driver never throw an exception but catch them on the public methods available to the Storage and simply return NULL value results or empty arrays in such a case.

#6 Updated by Andreas Wolf almost 2 years ago

  • Is Regression set to No

Catching exceptions is the responsibility of the UI/control logic, because it knows best how to deal with them - display a message, discard them or just let the whole operation fail. Driver exceptions could be wrapped by the Storage, to have unified exceptions, but that's not strictly necessary if we limit the types of exceptions that drivers might throw for certain operations.

#7 Updated by Steffen Ritter over 1 year ago

  • Assigned To changed from Bernhard Kraft to Steffen Ritter

#8 Updated by Steffen Ritter over 1 year ago

  • Parent task set to #54267

#9 Updated by Gerrit Code Review over 1 year ago

  • Status changed from Accepted to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26905

#10 Updated by Steffen Ritter over 1 year ago

  • % Done changed from 0 to 50

#11 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26905

#12 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26905

#13 Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26905

#14 Updated by Steffen Ritter over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 50 to 100

#15 Updated by Georg Ringer 8 months ago

works now, can't reproduce in master.

Also available in: Atom PDF