Feature #51713

Improve rendering of large exceptions

Added by Bastian Waidelich almost 2 years ago. Updated almost 2 years ago.

Status:Resolved Start date:2013-09-04
Priority:Should have Due date:
Assigned To:Bastian Waidelich % Done:

100%
Category:Error
Target version:-
PHP Version: Complexity:
Has patch:No

Description

Exceptions with a long message are hard to read when rendered with the DebugExceptionHandler currently:

Things could be improved by running the message through nl2br() and reducing the font weight

Before_short.png (27.6 kB) Bastian Waidelich, 2013-09-04 12:15

Before_short_nested.png (45.8 kB) Bastian Waidelich, 2013-09-04 12:15

Before_large.png (39.4 kB) Bastian Waidelich, 2013-09-04 12:15

Before_large_nested.png (62.3 kB) Bastian Waidelich, 2013-09-04 12:15

After_short.png (28.7 kB) Bastian Waidelich, 2013-09-04 12:16

After_short_nested.png (47.3 kB) Bastian Waidelich, 2013-09-04 12:16

After_large.png (41.7 kB) Bastian Waidelich, 2013-09-04 12:16

After_large_nested.png (66.4 kB) Bastian Waidelich, 2013-09-04 12:16

Iframe.png (124.8 kB) Bastian Waidelich, 2013-09-04 12:24

Associated revisions

Revision ebfb00bf
Added by Bastian Waidelich almost 2 years ago

[FEATURE] Improve rendering of large exceptions

Splits exception messages containting multiple sentences and/or
line breaks into "subject" and "body" and renders the body with
nl2br().

Change-Id: I432aaf5a3468903c3f91917c2373cebc9887a8ef
Resolves: #51713
Releases: master

History

#3 Updated by Bastian Waidelich almost 2 years ago

Before

Short:

Short (nested exception):

Large:

Large (nested exception):

Afterwards

Short:

Short (nested exception):

Large:

Large (nested exception):

#4 Updated by Bastian Waidelich almost 2 years ago

Just an idea I wanted to check out: The exception renderer checking if the "more information" page exists and inserts it as IFrame if so.. Too invasive IMO, but this would be the result:

#5 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23659

#6 Updated by Bastian Waidelich almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF