Bug #52130: Workspace->getRootNode() return NodeData, not Node(Interface) - TYPO3.TYPO3CR - TYPO3 Forge

Base Distribution TYPO3.Form TYPO3.Imagine TYPO3.Media TYPO3.Neos TYPO3.Neos.NodeTypes TYPO3.Party TYPO3.Setup TYPO3.SiteKickstarter TYPO3.Twitter.Bootstrap TYPO3.TYPO3CR TYPO3.TypoScript Coordination Group Website and Communication

Bug #52130

Workspace->getRootNode() return NodeData, not Node(Interface)

Added by Karsten Dambekalns almost 2 years ago. Updated almost 2 years ago.

Status:

Resolved

Start date:

2013-09-19

Priority:

Must have

Due date:

Assigned To:

Karsten Dambekalns

% Done:

100%

Category:

Node handling

Target version:

Base Distribution - 1.0 alpha 6

Description

This exposes the internal NodeData instance and breaks the use of the returned node in anything that expects Node(Interface) via type hinting.

Associated revisions

Revision 3f09dbd5
Added by Karsten Dambekalns almost 2 years ago

[TASK] Rename createFromNode() to createFromNodeData()

Since this method in NodeFactory creates a Node from NodeData, it should
have a matching name.

Change-Id: Ib8578d88670e294110a6df4cdd34afeddb11f138
Related: #52130
Reviewed-on: https://review.typo3.org/23900
Reviewed-by: Aske Ertmann
Reviewed-by: Robert Lemke
Tested-by: Robert Lemke

Revision fb7bb9e4
Added by Karsten Dambekalns almost 2 years ago

[BUGFIX] getRootNode() returns NodeData despite the name

The name implies that a Node(Interface) instance is used, but in fact
NodeData is returned.

This change renames it to getRootNodeData() to be consistent and avoid
confusion.

Change-Id: If5aee99d036e1da51e0d04fa52bda8c4d0015183
Fixes: #52130
Reviewed-on: https://review.typo3.org/23901
Reviewed-by: Aske Ertmann
Reviewed-by: Robert Lemke
Tested-by: Robert Lemke