Bug #52133

Display title of related record when using fields of type:inline as TCA label

Added by Benjamin Rau almost 2 years ago. Updated about 1 year ago.

Status:Resolved Start date:2013-09-19
Priority:Must have Due date:
Assigned To:- % Done:

100%
Category:Backend User Interface Spent time: -
Target version:-
TYPO3 Version:6.1 Is Regression:No
PHP Version:5.4 Sprint Focus:
Complexity:no-brainer

Description

If you want to use an inline field (1:1 relation) as label for your TCA table the UID of related record is shown as value, but it is expected to use the TCA label from the related table.

Reason why this is not shown:
TYPO3\CMS\Backend\Utility\BackendUtility::getProcessedValue() is used to get value that is used for the TCA label.

This one contains a switch which handles some field types differently, for example selects with foreign_table or group fields from internal_type db.

Suggested solution:
There is simply missing a case for fields of type:inline. Just handle it like value is processed for fields of type select.

Related issues

related to Core - Bug #59656: List mode doesn't show relation number, but tries to get ... Closed 2014-06-18
related to Core - Bug #22970: t3lib_BEfunc::getProcessedValue() did not handle TCA type... Rejected 2010-06-23

Associated revisions

Revision 807b5919
Added by Claus Due almost 2 years ago

[BUGFIX] Display relations' titles when TCA label field is type inline

This change adds a case to treat "inline" TCA types the same way
"select" is treated when building the record's label value.

Before, if record used field of type "inline" as TCA label field, TYPO3
would display fx "3" (number of related records as stored in field
on parent record).

After, TYPO3 will display fx "Record1, Record2, Record2" if "inline"
field contains three related records named thusly.

Fixes: #52133
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Ie06f09368e81505cb1e5989b61ae98add54b05ba
Reviewed-on: https://review.typo3.org/23902
Reviewed-by: Benjamin Rau
Tested-by: Benjamin Rau
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Cedric Ziel
Tested-by: Cedric Ziel
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Revision 765882ed
Added by Stefan Froemken over 1 year ago

[BUGFIX] Display relations' titles when TCA label field is type inline

This change adds a case to treat "inline" TCA types the same way
"select" is treated when building the record's label value.

Before, if record used field of type "inline" as TCA label field, TYPO3
would display fx "3" (number of related records as stored in field
on parent record).

After, TYPO3 will display fx "Record1, Record2, Record2" if "inline"
field contains three related records named thusly.

Fixes: #52133
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Ie06f09368e81505cb1e5989b61ae98add54b05ba
Reviewed-on: https://review.typo3.org/23914
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Revision f3b87113
Added by Stefan Froemken over 1 year ago

[BUGFIX] Display relations' titles when TCA label field is type inline

This change adds a case to treat "inline" TCA types the same way
"select" is treated when building the record's label value.

Before, if record used field of type "inline" as TCA label field, TYPO3
would display fx "3" (number of related records as stored in field
on parent record).

After, TYPO3 will display fx "Record1, Record2, Record2" if "inline"
field contains three related records named thusly.

Fixes: #52133
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Ie06f09368e81505cb1e5989b61ae98add54b05ba
Reviewed-on: https://review.typo3.org/23913
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Revision 96ff9279
Added by Claus Due over 1 year ago

[BUGFIX] Display relations' titles when TCA label field is type inline

This change adds a case to treat "inline" TCA types the same way
"select" is treated when building the record's label value.

Before, if record used field of type "inline" as TCA label field, TYPO3
would display fx "3" (number of related records as stored in field
on parent record).

After, TYPO3 will display fx "Record1, Record2, Record2" if "inline"
field contains three related records named thusly.

Fixes: #52133
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Ie06f09368e81505cb1e5989b61ae98add54b05ba
Reviewed-on: https://review.typo3.org/23912
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Revision 42a3eb3b
Added by Claus Due over 1 year ago

[BUGFIX] Display relations' titles when TCA label field is type inline

This change adds a case to treat "inline" TCA types the same way
"select" is treated when building the record's label value.

Before, if record used field of type "inline" as TCA label field, TYPO3
would display fx "3" (number of related records as stored in field
on parent record).

After, TYPO3 will display fx "Record1, Record2, Record2" if "inline"
field contains three related records named thusly.

Fixes: #52133
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Ie06f09368e81505cb1e5989b61ae98add54b05ba
Reviewed-on: https://review.typo3.org/23911
Reviewed-by: Markus Klein
Tested-by: Markus Klein

History

#1 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23902

#2 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23902

#3 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/23911

#4 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/23911

#5 Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/23911

#6 Updated by Anonymous almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/23912

#8 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/23913

#9 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/23914

#10 Updated by Anonymous over 1 year ago

  • Status changed from Under Review to Resolved

#11 Updated by Caspar Stuebs about 1 year ago

This fix in uncomplete.

To handle TCA type inline, some more lines of code are needed.

Please see Ticket #22970 - Patch is submitted to gerrit since 9 month

Also available in: Atom PDF