Bug #52425

"Required option" flag in AbstractValidatior does not work correct

Added by Michael Gerdemann almost 2 years ago. Updated almost 2 years ago.

Status:Resolved Start date:2013-10-01
Priority:Should have Due date:
Assigned To:- % Done:

100%

Category:-
Target version:-
PHP Version: Complexity:
Has patch:Yes Affected Flow version:Flow 2.0.0

Description

The "required" flag for the options in source:/Classes/TYPO3/Flow/Validation/Validator/AbstractValidator.php does not work correct.
If the flag is set to FALSE, the option is nevertheless TRUE.

Example (does not work):

protected $supportedOptions = array(
    'optionName'   => array('default, 'Description', 'mixed', FALSE)
);

patch.diff Magnifier (912 Bytes) Michael Gerdemann, 2013-10-01 11:52

Associated revisions

Revision 9e5f2e40
Added by Michael Gerdemann almost 2 years ago

[BUGFIX] "Required option" flag in AbstractValidator works correct

This fix adds a boolean condition to the "Required option" flag
condition. With this fix the flag can also be FALSE.

Fixes: #52425
Change-Id: If174b3223f0a2d48650697548cf15d5e8705cbb3
Releases: master, 2.0

Revision de5ed467
Added by Michael Gerdemann almost 2 years ago

[BUGFIX] "Required option" flag in AbstractValidator works correct

This fix adds a boolean condition to the "Required option" flag
condition. With this fix the flag can also be FALSE.

Fixes: #52425
Change-Id: If174b3223f0a2d48650697548cf15d5e8705cbb3
Releases: master, 2.0

History

#1 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24211

#2 Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24211

#3 Updated by Gerrit Code Review almost 2 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24211

#4 Updated by Gerrit Code Review almost 2 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24211

#5 Updated by Gerrit Code Review almost 2 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24211

#6 Updated by Gerrit Code Review almost 2 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24211

#7 Updated by Gerrit Code Review almost 2 years ago

Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24211

#8 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/24386

#9 Updated by Michael Gerdemann almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF