Task #52452
Refactor router caching logic into a service
| Status: | Resolved | Start date: | 2013-10-02 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Tim Kandel | % Done: | 100% |
|
| Category: | MVC - Routing | |||
| Target version: | TYPO3 Flow Base Distribution - 2.1 | |||
| Sprint: | Has patch: | No | ||
| PHP Version: | Complexity: |
Description
Currently the logic for fetching the routing cache and creating it resides solely in the RouterCachingAspect. This makes it hard for us and for userland code to work with this cache without having to repeat the code. Instead of using the Aspect, there should be a Service that implements all neccessary methods.
Related issues
Associated revisions
[TASK] Refactor router caching logic into a service
This change removes most of the logic from the
RouterCachingAspect and introduces it in the form of a new
RouterCachingService.
Change-Id: I1a24b4192f46d38593e4bd01e9d1a620d8fee48e
Resolves: #52452
Releases: master
[TASK] Cleanup RouterCachingService
Some (mostly cosmetic) adjustments to our CGL and some
renamings to increase readability.
This also renames the misleading method Route::getMatchingUri()
by Route::getResolvedUriPath(). The old method is still available as
deprecated alias.
Change-Id: I2e671d1bb0f27fee74cc027a6e5016817c7303dd
Related: #52452
Releases: master
[TASK] Get rid of RouterCachingAspect
This moves code from the RouterCache AOP aspect to the Router itself
making the aspect redundant.
Before the cache handling of the Routing Framework has been extracted
to an AOP aspect in order to keep the Router code simple. Since the
introduction of the RouterCachingService (#52452) this is no longer
required.
Change-Id: I43fc35c55fdb69e1e67e08782ab0928bc37218de
Resolves: #52704
Related: #52452
Releases: master
History
#1 Updated by Gerrit Code Review almost 2 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24242
#2 Updated by Gerrit Code Review almost 2 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24242
#3 Updated by Gerrit Code Review almost 2 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24242
#4 Updated by Gerrit Code Review almost 2 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24242
#5 Updated by Gerrit Code Review almost 2 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24242
#6 Updated by Gerrit Code Review almost 2 years ago
Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24242
#7 Updated by Gerrit Code Review almost 2 years ago
Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24242
#8 Updated by Tim Kandel almost 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset a60ef3c8672ff70b62f799ff6ea6ad1323f18a85.