Bug #52527

ExtensionManagementUtility::addToAllTCAtypes() doesn't add field because of match on substring

Added by Peter Niederlag almost 2 years ago. Updated about 1 year ago.

Status:Resolved Start date:2013-10-04
Priority:Must have Due date:
Assigned To:- % Done:

100%
Category:- Spent time: -
Target version:-
TYPO3 Version:6.0 Is Regression:No
PHP Version: Sprint Focus:
Complexity:medium

Description

If you have a field 'great_categories' you can't add another field on the same table with addToAllTCAtypes() with a name of 'categories' as this field is considerd existing in the routine. this is most likely happening due to the use of

strpos($typeDetails['showitem'], $str) !== FALSE

Associated revisions

Revision 48eab767
Added by Tomita Militaru over 1 year ago

[BUGFIX] addToAllTCAtypes() doesn't add new field

Fixes problem with match on substring when adding a new field
using ExtensionManagementUtility::addToAllTCAtypes()

Resolves: #52527
Releases: 6.1, 6.0
Change-Id: I8877cdabc00f5ac64f1f7857bf47c275d36aae62
Reviewed-on: https://review.typo3.org/27663
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Revision a335bcfa
Added by Tomita Militaru over 1 year ago

[BUGFIX] addToAllTCAtypes() doesn't add new field

Fixes problem with match on substring when adding a new field
using ExtensionManagementUtility::addToAllTCAtypes()

Resolves: #52527
Releases: 6.1, 6.0
Change-Id: I8877cdabc00f5ac64f1f7857bf47c275d36aae62
Reviewed-on: https://review.typo3.org/27671
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Revision 30f2ba08
Added by Christian Kuhn about 1 year ago

[TASK] Tests: Refactor and activate dbal tests

Our unit test environment is finally ready to execute existing dbal
unit tests, even if no database connection exists.

The patch refactors unit tests of ext:dbal, modernizes their codebase
and adds them to the build.

Resolves: #52527
Related: #51436
Releases: 6.2
Change-Id: I70507591dc89331d658d50196dfcaea002caa7d5
Reviewed-on: https://review.typo3.org/29874
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

History

#1 Updated by Peter Niederlag almost 2 years ago

$tmpField1 = array (
    'fancy_field_test' => array(
        'exclude' => 0,
        'label' => 'first working test',
        'config' => array(
            'type' => 'input',
            'size' => 30,
            'eval' => 'trim,required'
        )
    )
);
$tmpField2 = array (
    'test' => array(
        'exclude' => 0,
        'label' => 'second (failing) test',
        'config' => array(
            'type' => 'input',
            'size' => 30,
            'eval' => 'trim,required'
        )
    )
);
\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addTCAcolumns('pages', $tmpField1);
\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addToAllTCATypes('pages', 'fancy_field_test');
\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addTCAcolumns('pages',$tmpField2);
\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addToAllTCATypes('pages', 'test');

tmpField2 won't show up :(
'test' is part of 'fancy_field_test'
reversing the registration order would fix it

#2 Updated by Philipp Gampe almost 2 years ago

  • Status changed from New to Accepted
  • Priority changed from Should have to Must have
  • TYPO3 Version changed from 6.2 to 6.0
  • Complexity set to medium

Should go to all 6.x versions I guess (and maybe even to 4.5).

Can you work on a patch (and put the example into a unit test)? This would be great.

#3 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/25127

#4 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/25127

#5 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25127

#6 Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27663

#7 Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch TYPO3_6-0 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27671

#8 Updated by Tomita Militaru over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#9 Updated by Gerrit Code Review about 1 year ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29874

#10 Updated by Christian Kuhn about 1 year ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF