Bug #52557
Show message and disallow modification of non DefaultConfiguration values in install tool
| Status: | Under Review | Start date: | 2013-10-06 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | - | % Done: | 0% |
|
| Category: | Install Tool | Spent time: | - | |
| Target version: | - | |||
| TYPO3 Version: | 6.2 | Is Regression: | No | |
| PHP Version: | Sprint Focus: | |||
| Complexity: |
Description
If you override a setting in the AdditionalConfiguration.php the value is displayed in the install tool. If you change the value you get a positive message that it has been changed. But if you look again in the install tool the "old" value is displayed again. This is because the install tool only writes to the LocalConfiguration which is then overwritten by the AdditionalConfiguration.php.
There should be a notice that the value has been changed outside of the LocalConfiguration and therefore can't be changed in the install tool. The field should also be disabled so it can't be changed.
Values that are not part of the DefaultConfiguration should also be not editable and a message should be displayed that this setting is not part of the default TYPO3 configuration.
Related issues
History
#1 Updated by Gerrit Code Review almost 2 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24421
#2 Updated by Gerrit Code Review almost 2 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24421
#3 Updated by Gerrit Code Review almost 2 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24421
#4 Updated by Nicole Cordes 8 months ago
Sascha Egerer wrote:
If you override a setting in the AdditionalConfiguration.php the value is displayed in the install tool. If you change the value you get a positive message that it has been changed. But if you look again in the install tool the "old" value is displayed again. This is because the install tool only writes to the LocalConfiguration which is then overwritten by the AdditionalConfiguration.php.
There should be a notice that the value has been changed outside of the LocalConfiguration and therefore can't be changed in the install tool. The field should also be disabled so it can't be changed.
I confirm this should be added to prevent confusion
Values that are not part of the DefaultConfiguration should also be not editable and a message should be displayed that this setting is not part of the default TYPO3 configuration.
Do you have any arguments why those options shouldn't be editable?
#5 Updated by Sascha Egerer 8 months ago
Nicole Cordes wrote:
Values that are not part of the DefaultConfiguration should also be not editable and a message should be displayed that this setting is not part of the default TYPO3 configuration.
Do you have any arguments why those options shouldn't be editable?
AFAIK they have not been saved by the install tool if they are not part of the DefaultConfiguration. But i'm not sure anymore.