Bug #52828

extTables cache file creation does not respect extension order

Added by Philipp Gampe almost 2 years ago. Updated over 1 year ago.

Status:Resolved Start date:2013-10-15
Priority:Must have Due date:
Assigned To:- % Done:

100%

Category:- Spent time: -
Target version:6.2.0
TYPO3 Version:6.2 Is Regression:No
PHP Version:5.5 Sprint Focus:
Complexity:hard

Description

All extTables.php are included in the alphabetical order off the extension keys.

They must be ordered by dependencies.


Related issues

related to Core - Bug #52984: PackageManager resolving dependencies uses folderstructur... Rejected 2013-10-20
related to Core - Bug #53178: Package loading order does not respect Extension dependen... Closed 2013-10-28
related to TYPO3.Flow - Feature #54151: Implement proper package dependency handling Resolved 2013-12-02

Associated revisions

Revision a71add78
Added by Markus Klein almost 2 years ago

[BUGFIX] Sorting of packages by dependency

Implement proper dependency handling in Flow PackageManager.
The code ensures that all framework packages are loaded first.

Releases: 6.2
Resolves: #52828
Change-Id: I6717756efae28b1f8e13fc3a251328f69f54b4d4
Reviewed-on: https://review.typo3.org/24852
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

History

#1 Updated by Helmut Hummel almost 2 years ago

  • Status changed from New to Accepted
  • Target version set to 6.2.0

I identified two issues:

  1. The dependencies of system extensions are not set correctly (e.g. openid extension should depend on setup as it adds a user setup field). Along side with this, TER Extensions need to be more specific what their dependencies are to be ordered correctly
  2. PackageManager::sortAvailablePackagesByDependencies() does not work correctly. Packages are not correctly ordered by dependency in certain cases (needs more checks to find the issues there)

#2 Updated by Helmut Hummel almost 2 years ago

  • Complexity changed from easy to hard

#3 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Accepted to Under Review

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24852

#4 Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24852

#5 Updated by Gerrit Code Review almost 2 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24852

#6 Updated by Gerrit Code Review almost 2 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24852

#7 Updated by Gerrit Code Review almost 2 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24852

#8 Updated by Gerrit Code Review almost 2 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24852

#9 Updated by Gerrit Code Review almost 2 years ago

Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24852

#10 Updated by Gerrit Code Review almost 2 years ago

Patch set 9 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24852

#11 Updated by Gerrit Code Review almost 2 years ago

Patch set 10 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24852

#12 Updated by Gerrit Code Review almost 2 years ago

Patch set 11 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24852

#13 Updated by Gerrit Code Review almost 2 years ago

Patch set 12 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24852

#14 Updated by Gerrit Code Review almost 2 years ago

Patch set 13 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24852

#15 Updated by Gerrit Code Review almost 2 years ago

Patch set 14 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24852

#16 Updated by Gerrit Code Review almost 2 years ago

Patch set 15 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24852

#17 Updated by Gerrit Code Review almost 2 years ago

Patch set 16 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24852

#18 Updated by Gerrit Code Review almost 2 years ago

Patch set 17 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24852

#19 Updated by Markus Klein almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#20 Updated by Markus Klein over 1 year ago

For documentation, these two concepts were used in the patch:

Also available in: Atom PDF