Bug #52835

File module: missing icon "edit" in context menu

Added by Fabien Udriot almost 2 years ago. Updated over 1 year ago.

Status:Resolved Start date:2013-10-15
Priority:Should have Due date:
Assigned To:Steffen Ritter % Done:

100%
Category:File Abstraction Layer (FAL) Spent time: -
Target version:6.2.0 Estimated time:0.50 hour
TYPO3 Version:6.2 Is Regression:No
PHP Version: Sprint Focus:
Complexity:no-brainer

Description

In File module, the "edit" icon is missing in context menu even for Admin User.

ScreenShot-2013-10-15.png (112.7 kB) Fabien Udriot, 2013-10-15 10:53

edit-file.png (15.4 kB) Steffen Müller, 2013-11-30 22:06

Associated revisions

Revision e0c68ddf
Added by Steffen Ritter over 1 year ago

[TASK] Add editing of file metadata to ClickMenu

The Context-Menu of files misses the editing pen allowing
to directly edit the metadata of the file. Currently it
only shows the edit-content possibility in case it is a
text file.

This patch adds the missing option.

Resolves: #52835
Releases: 6.2
Change-Id: I869d8a57d2cacc04455df5189b5cc7af02c2e9cf
Reviewed-on: https://review.typo3.org/25811
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

History

#1 Updated by Fabien Udriot almost 2 years ago

  • File Screen_Shot_2013-10-15_at_10.45.12_AM.png added

#2 Updated by Fabien Udriot almost 2 years ago

  • File deleted (Screen_Shot_2013-10-15_at_10.45.12_AM.png)

#4 Updated by Steffen Ritter over 1 year ago

  • Status changed from New to Accepted
  • Assigned To set to Steffen Ritter

#5 Updated by Gerrit Code Review over 1 year ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25811

#6 Updated by Steffen Ritter over 1 year ago

  • Complexity set to no-brainer

#7 Updated by Steffen Ritter over 1 year ago

  • % Done changed from 0 to 100
  • Estimated time set to 0.50

#8 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25811

#9 Updated by Steffen Müller over 1 year ago

Having two items labeled with "edit" is ambiguous to the user.

#10 Updated by Stefan Neufeind over 1 year ago

The first one is added: edit meta-data (actually: edit the "record").
The second one existed before. Imho this is the one which is "out of line" from a programmers POV because it doesn't edit the record you clicked on, like we usually do, but instead edits the referenced object (the file it points to).

#11 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25811

#12 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25811

#13 Updated by Steffen Ritter over 1 year ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF