Bug #52923
The CaseImplementation does not support TypoScript debug mode correctly
| Status: | Resolved | Start date: | 2013-10-17 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Dominique Feyer | % Done: | 100% |
|
| Category: | - | |||
| Target version: | - |
Description
$renderedMatcher !== self::MATCH_NORESULT is always FALSE when using TypoScript debug mode something like if (strpos($renderedMatcher, self::MATCH_NORESULT) === FALSE) should work
Associated revisions
[BUGFIX] Support debug mode for CaseImplementation
The Case object did not match result correctly in debug mode, since the
rendered output of a matcher is annotated with debug comments and does
not equal the MATCH_NORESULT constant.
This change strips these comments from the rendered output if the debug
mode is enabled before comparing the strings.
To test the behavior a setter for the debug mode was introduced to the
TypoScript Runtime and an option was added to the TypoScriptView.
Change-Id: Ic0d24ddfb35a62a49f4e1d959a4dbe892c260d14
Fixes: #52923
Reviewed-on: https://review.typo3.org/24955
Tested-by: Mr. Hudson
Reviewed-by: Dominique Feyer
Tested-by: Dominique Feyer
Reviewed-by: Christopher Hlubek
Tested-by: Christopher Hlubek
Reviewed-by: Sebastian Kurfuerst
Tested-by: Sebastian Kurfuerst
History
#1 Updated by Dominique Feyer almost 2 years ago
- Project changed from TYPO3.Neos to TYPO3.TypoScript
#2 Updated by Gerrit Code Review almost 2 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24955
#3 Updated by Gerrit Code Review almost 2 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24955
#4 Updated by Christopher Hlubek almost 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 405dd1c3cb50c0dc46526cdc3f1b0b24388b0fd7.