Bug #53097
MEDIA / renderType / impossible to use custom renderType for video
| Status: | New | Start date: | 2013-10-24 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | - | % Done: | 0% |
|
| Category: | Frontend | Spent time: | - | |
| Target version: | - | |||
| TYPO3 Version: | 6.1 | Is Regression: | Yes | |
| PHP Version: | 5.4 | Sprint Focus: | ||
| Complexity: | medium |
Description
hiya!
the if structure on line 178 (and following) in sysext/frontend/Classes/ContentObject/MediaContentObject.php always sets $renderType to 'swf',
so it’s impossible to use a custom renderType for video
the problem (imho) is the combination of
178 if ($renderType !== 'qt' && $renderType !== 'embed' && $conf['type'] == 'video') {
and
192 } elseif (isset($conf['file']) && !isset($conf['caption']) && !isset($conf['sources'])) {
193 $renderType = 'swf';
as a result $renderType is always 'swf' for video
or do I miss something here (guess not)?
possibly related to http://forge.typo3.org/issues/38376
Related issues
History
#1 Updated by Philipp Gampe almost 2 years ago
- Status changed from New to Needs Feedback
- Complexity set to medium
- Is Regression changed from No to Yes
I think this is a regression introduced with #33357
To me it looks like the patch does not take custom render types into account.
You should be able to avoid this condition by setting a caption or a source.
Can you confirm that its is working then.
#2 Updated by Wolfgang Klinger over 1 year ago
Yes, setting a caption or source fixes the problem
#3 Updated by Alexander Opitz over 1 year ago
- Status changed from Needs Feedback to New
#4 Updated by Wolfgang Klinger over 1 year ago
The problem arises again if I want to use e.g. a youtube URL as media,
because then the if condition on line 179 matches and sets the renderType to 'swf' again
(though I don’t like to have to add a caption and/or source as „solution“ for local media anyway)
Will this get fixed anytime soon? Any other workaround ideas other than hacking the core?
#5 Updated by Frans Saris 11 months ago
I'm working on a prototype to make it possible to register your own "render" helpers. Have a look at https://github.com/fsaris/fal_online_media_connector
It also makes it possible to have a text+media element instead only text+image