Bug #53238
Throw exception if PackageStates.php is not writeable
| Status: | Resolved | Start date: | 2013-10-30 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | - | % Done: | 100% |
|
| Category: | - | |||
| Target version: | - | |||
| PHP Version: | Complexity: | |||
| Has patch: | No | Affected Flow version: | Flow 2.0.0 |
Description
The Package Manager writes package states to PackageStates.php file using
file_put_contents()
together with the error control operator @ to suppress errors.
This leads to unpredictable behavior when PackageStates.php file is not writeable.
I suggest to verify if the file is writable and otherwise throw an exception.
TYPO3 CMS team has already a draft at https://review.typo3.org/#/c/24975/ - would you please comment there or here, since we aim to streamline with upstream Flow.
Related issues
Associated revisions
[BUFGIX] Throw exception if PackageStates.php is not writeable
Change-Id: I6dbe4f52bb13bfeb893a88c0e235a1cdcf2cf441
Fixes: #53238
Releases: master, 2.1
[BUFGIX] Throw exception if PackageStates.php is not writeable
Change-Id: I6dbe4f52bb13bfeb893a88c0e235a1cdcf2cf441
Fixes: #53238
Releases: master, 2.1
History
#1 Updated by Gerrit Code Review almost 2 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/25120
#2 Updated by Gerrit Code Review almost 2 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/25120
#3 Updated by Gerrit Code Review over 1 year ago
Patch set 3 for branch master of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at https://review.typo3.org/25120
#4 Updated by Gerrit Code Review over 1 year ago
Patch set 4 for branch master of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at https://review.typo3.org/25120
#5 Updated by Gerrit Code Review over 1 year ago
Patch set 1 for branch 2.1 of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at https://review.typo3.org/28122
#6 Updated by Wouter Wolters over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 1781926870db735f5b32db6b9fe0199a6f4e99e6.