Bug #53368
Use getPagesTSconfig($tscPID) only once per ID
| Status: | Resolved | Start date: | 2013-11-06 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assigned To: | - | % Done: | 100% |
|
| Category: | Performance | Spent time: | - | |
| Target version: | 6.2.0 | |||
| TYPO3 Version: | 6.2 | Is Regression: | No | |
| PHP Version: | 5.4 | Sprint Focus: | ||
| Complexity: |
Description
PageLayoutView::isRTEforField is called on every record that is displayed in a Web>Page. And this will call BackendUtility::getPagesTSconfig($tscPID) every time once and again, and thus parsing the PageTS over and over on the same hit. If you have 50 content elements on a page, this can get very expensive.
Solution: Create a variable that stores the RTEsetup for a particular ID
Related issues
Associated revisions
[BUGFIX] Use getPagesTSconfig($tscPID) only once per ID
PageLayoutView::isRTEforField is called on every record that is
displayed in a Web>Page. And this will call
BackendUtility::getPagesTSconfig($tscPID)
every time once and again,
and thus parsing the PageTS over and over on the same hit.
If you have 50 content elements on a page,
this can get very expensive.
Solution: Create a variable that stores the RTEsetup for
a particular ID
Resolves: #53368
Releases: 6.2
Change-Id: I7efcefb0c12c856e9417ca8bb655acaabd4f15cc
Reviewed-on: https://review.typo3.org/25181
Reviewed-by: Oliver Klee
Reviewed-by: Jo Hasenau
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Sebastian Fischer
Reviewed-by: Wouter Wolters
Reviewed-by: Peter Foerger
Tested-by: Peter Foerger
Tested-by: Philipp Gampe
Reviewed-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
History
#1 Updated by Gerrit Code Review over 1 year ago
- Status changed from New to Under Review
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25181
#2 Updated by Gerrit Code Review over 1 year ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25181
#3 Updated by Jo Hasenau over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset c9cd9c40ef9e24cf179c172489508987f050ea02.