Bug #53478
Performance: remove unneeded basename call in CacheManager
| Status: | Resolved | Start date: | 2013-11-09 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | - | % Done: | 100% |
|
| Category: | Performance | Spent time: | - | |
| Target version: | - | |||
| TYPO3 Version: | 6.2 | Is Regression: | No | |
| PHP Version: | Sprint Focus: | |||
| Complexity: | easy |
Description
TYPO3\CMS\Core\Cache\CacheManager
Line 233
$filename = basename($pathAndFilename);
but lines afterwards in if is checked again against basename($pathAndFilename)
Related issues
Associated revisions
[BUGFIX] Performance: remove unneeded basename call in CacheManager
$filename is already containing basername from $pathAndFilename
thus replace in if and else basename($pathAndFilename) by
filename
Resolves: #53478
Releases: 6.2
Change-Id: Ia71d4ec654edd6effb7c8b290d0738f5f1a77bb4
Reviewed-on: https://review.typo3.org/25245
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
History
#1 Updated by Gerrit Code Review over 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25245
#2 Updated by Ingo Schmitt over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset e59fe358f40e68a3d3f5389d5b6ba8ec1b0642e7.