Task #53655

Epic #55070: Workpackages

Epic #54260: WP: FAL Missing Issues / Features / API

Story #54267: As an Editor I want to use a FAL withouth bugs

Wrong path in Frontend on moving directory in fileadmin

Added by Stefan Weißwange over 1 year ago. Updated over 1 year ago.

Status:Resolved Start date:2013-11-15
Priority:Must have Due date:
Assigned To:Steffen Ritter % Done:

100%

Category:File Abstraction Layer (FAL) Spent time: -
Target version:6.2.0 Estimated time:0.00 hour
TYPO3 Version:6.1 Complexity:medium
PHP Version:5.4 Sprint Focus:

Description

I have cut'n'pasted a folder in the fileadmin directory to another directory:
from /fileadmin/library/marketing/ to /fileadmin/library/resources/pr/marketing/.

Assets, used in content elements (fileadmin/library/marketing/image.png) which worked before the cut'n'paste dont show up afterwards, because the frontend is using a (partly) wrong path, the Image-Source references library/resources/pr/marketing/image.png. The fileadmin folder is missing in the path.

As a quick'n'dirty workaround if symlinked library to fileadmin/library, then the image is processed and displayed as accepted.


Related issues

related to Core - Bug #54499: Fix test: LocalDriver does not update file-properties any... Resolved 2013-12-18

Associated revisions

Revision fc696569
Added by Frans Saris over 1 year ago

[BUGFIX] Moving files and folders doesn't update hashes

The ResourceStorage does not properly make use of the Indexer.
As result the indexRecord is not properly updated after a
file change.

This patch cleans up the ResourceStorage so it doesn't update
the index properties itself but leaves that to the indexer.

Resolves: #53655
Releases: 6.2
Change-Id: I249505a1bc0b93f8b3ffb0e9cb2b7f10a9a9968e
Reviewed-on: https://review.typo3.org/25481
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

History

#1 Updated by Stefan Weißwange over 1 year ago

To reproduce:
  1. Create a directory in fileadmin (fileadmin/Bibliothek/test/testlibrary/)
  2. Upload image in directory (image.png)
  3. Use image within textpic
  4. Image is processed like expected (<img src="/fileadmin/_processed/csm_image_935ce2192e.png" />_)
  5. Cut'n'Paste folder to another folder (fileadmin/Bibliothek/test/another_testfolder/testlibrary/)
  6. Reload Page in Frontend, imagepath is wrong and image does not show up (<img src="/Bibliothek/test/another_testfolder/testlibrary/image.png" />)
  7. create symlink in Document Root (ln -s fileadmin/Bibliothek/ Bibliothek)
  8. Image is processed like expected (<img src="/typo3temp/_processed/csm_image_935ce2192e.png" />_)

#2 Updated by Markus Klein over 1 year ago

  • Status changed from New to Accepted

#3 Updated by Frans Saris over 1 year ago

Could you test this with current master? I think #53614 fixed this issue. Can not reproduce the problem as you describe.

#4 Updated by Frans Saris over 1 year ago

Just checked again, you're right. When moving the whole folder the hash values in sys_file aren't updated.

#5 Updated by Gerrit Code Review over 1 year ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25481

#6 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25481

#7 Updated by Steffen Ritter over 1 year ago

  • Target version changed from next-patchlevel to 6.2.0

This won't be fixed for 6.0 and 6.1 since the FAL in these branches has to many conceptional flaws

#8 Updated by Steffen Ritter over 1 year ago

  • Assigned To set to Steffen Ritter

#9 Updated by Steffen Ritter over 1 year ago

  • % Done changed from 0 to 100
  • Estimated time set to 0.00
  • Complexity set to medium

#10 Updated by Steffen Ritter over 1 year ago

  • Parent task set to #54267

#11 Updated by Steffen Ritter over 1 year ago

  • % Done changed from 100 to 70

#12 Updated by Frans Saris over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 70 to 100

#13 Updated by Steffen Ritter over 1 year ago

  • % Done changed from 100 to 90

#14 Updated by Steffen Ritter over 1 year ago

  • % Done changed from 90 to 100

Also available in: Atom PDF