Bug #53918
Epic #55070: Workpackages
Epic #55065: WP: Overall System Performance (Backend and Frontend)
Bug #52949: Speed decrease since 4.5
t3skin calls addIconSprite for each language
| Status: | Resolved | Start date: | 2013-11-25 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | - | % Done: | 100% |
|
| Category: | Performance | Spent time: | - | |
| Target version: | next-patchlevel | |||
| TYPO3 Version: | 6.2 | Is Regression: | No | |
| PHP Version: | 5.3 | Sprint Focus: | ||
| Complexity: | no-brainer |
Description
The t3skin extension adds icon sprites for each language. And that's great, but not so great that it takes 22 ms to add all the icon sprites for each language and an overlay icon because the addIconSprite is called for each language.
Instead the iconArray can be built up and submitted once to addIconSprite.
This saves 248 calls to addIconSprite which calls array_merge etc.
This saves ~ 22 ms for each request.
Associated revisions
[BUGFIX] t3skin calls addIconSprite for each lang
The t3skin extension adds icon sprites for each language. And that's
great, but not so great that it calls addIconSprite for each language.
Instead the iconArray can be built up and submitted once to
addIconSprite.
This saves 248 calls to addIconSprite which calls array_merge etc.
This saves ~ 22 ms for each request.
Change-Id: I0fdc09de46899e4160f907aefd8b3b3b596a2df3
Resolves: #53918
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/25670
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
[BUGFIX] t3skin calls addIconSprite for each lang
The t3skin extension adds icon sprites for each language. And that's
great, but not so great that it calls addIconSprite for each language.
Instead the iconArray can be built up and submitted once to
addIconSprite.
This saves 248 calls to addIconSprite which calls array_merge etc.
This saves ~ 22 ms for each request.
Change-Id: I0fdc09de46899e4160f907aefd8b3b3b596a2df3
Resolves: #53918
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/25683
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
[BUGFIX] t3skin calls addIconSprite for each lang
The t3skin extension adds icon sprites for each language. And that's
great, but not so great that it calls addIconSprite for each language.
Instead the iconArray can be built up and submitted once to
addIconSprite.
This saves 248 calls to addIconSprite which calls array_merge etc.
This saves ~ 22 ms for each request.
Change-Id: I0fdc09de46899e4160f907aefd8b3b3b596a2df3
Resolves: #53918
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/25684
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
History
#1 Updated by Gerrit Code Review over 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25670
#2 Updated by Markus Klein over 1 year ago
- Parent task set to #52949
#3 Updated by Gerrit Code Review over 1 year ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25670
#4 Updated by Gerrit Code Review over 1 year ago
Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25683
#5 Updated by Gerrit Code Review over 1 year ago
Patch set 1 for branch TYPO3_6-0 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25684
#6 Updated by Michiel Roos over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 762cb0a01c4eecc534a60641709d321b1754d60e.
