Task #54012
Epic #55070: Workpackages
Epic #54260: WP: FAL Missing Issues / Features / API
Story #54263: As an Integrator I want to have my metadata present at places when using files
Inconsistent hasProperty method for files
| Status: | Resolved | Start date: | 2013-11-27 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assigned To: | Steffen Ritter | % Done: | 100% |
|
| Category: | File Abstraction Layer (FAL) | Spent time: | - | |
| Target version: | 6.2.0 | Estimated time: | 2.00 hours | |
| TYPO3 Version: | 6.2 | Complexity: | easy | |
| PHP Version: | 5.4 | Sprint Focus: |
Description
The hasProperty() method defined in the AbstractFile class is not valid for instances of the real File object.
Since the real File is also looking in its metaDataProperties the hasProperty() method should also checks these when it tries to determine if a property exists.
Currently hasProperty() would return FALSE, even if the requested property is available in the meta data.
Associated revisions
[BUGFIX] hasProperty ignores meta data properties
Since the split of sys_file to sys_file_metadata the data
is stored in different arrays. The hasProperty method of
AbstractFile is not overriden in File to consider that change.
Resolves: #54012
Releases: 6.2
Change-Id: Iab2b55e56795033c77c1e3f2969d927ba71a4ceb
Reviewed-on: https://review.typo3.org/26688
Reviewed-by: Alexander Stehlik
Tested-by: Alexander Stehlik
Reviewed-by: Frans Saris
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
History
#1 Updated by Steffen Ritter over 1 year ago
- Status changed from New to Accepted
- Assigned To set to Steffen Ritter
- Priority changed from Should have to Must have
- Estimated time set to 2.00
#2 Updated by Steffen Ritter over 1 year ago
- Parent task set to #54263
#3 Updated by Gerrit Code Review over 1 year ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26688
#4 Updated by Steffen Ritter over 1 year ago
- % Done changed from 0 to 70
#5 Updated by Gerrit Code Review over 1 year ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26688
#6 Updated by Gerrit Code Review over 1 year ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26688
#7 Updated by Steffen Ritter over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 70 to 100
Applied in changeset c108a3782506c0b61fbf46f3641452e253f46d7b.