Bug #54210

Dateselector goes forward but not backwards

Added by Thomas Hempel over 1 year ago. Updated over 1 year ago.

Status:Resolved Start date:2013-12-05
Priority:Should have Due date:
Assigned To:- % Done:

100%
Category:UI
Target version:-

Description

I know that Neos is for the future but it would be cool if the dateselector in the inspector could go back in time. ;-)

Seriously, only the arrow to the right works. The arrow to the left (go back in time) also goes forward.

Associated revisions

Revision 147da853
Added by Christian Müller over 1 year ago

[BUGFIX] Dateselector should do "previous" too

The dateselector incorrectly only moves forward
regardless of the arrow clicked, it should go back on the left
arrow and forward on the right arrow.

Credits for finding the broken part go to Thomas Hempel. Thanks!

Change-Id: If211b95bf87f074ed84851a891f71d1d7eff3156
Fixes: #54210
Releases: master, 1.0
Reviewed-on: https://review.typo3.org/26539
Reviewed-by: Rens Admiraal
Tested-by: Rens Admiraal

Revision 25e9112b
Added by Christian Müller over 1 year ago

[BUGFIX] Dateselector should do "previous" too

The dateselector incorrectly only moves forward
regardless of the arrow clicked, it should go back on the left
arrow and forward on the right arrow.

Credits for finding the broken part go to Thomas Hempel. Thanks!

Change-Id: If211b95bf87f074ed84851a891f71d1d7eff3156
Fixes: #54210
Releases: master, 1.0
Reviewed-on: https://review.typo3.org/26540
Reviewed-by: Rens Admiraal
Tested-by: Rens Admiraal
Reviewed-by: Christian Mueller
Tested-by: Christian Mueller

History

#1 Updated by Thomas Hempel over 1 year ago

There is an easy fix for this but I can't provide a patch

In the ContentModule-built.js

At position 378,500557-499338

There you'll find something like

r[0].className=="neos"?-1:1

This has to be

r[0].className="neos-prev"?-1:1

There is also another version in the file query-with-dependencies.js. In line 36332 (seriously?) you'll find

var dir = DPGlobal.modes[this.viewMode].navStep * (target[0].className == 'prev' ? -1 : 1);

Should be

var dir = DPGlobal.modes[this.viewMode].navStep * (target[0].className == 'neos-prev' ? -1 : 1);

I have no idea how all this works together and only if I changed it the "built" file, it has an effect.

Can someone please merge this asap?

Thanks and Greets,
Thomas

#2 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.Neos has been pushed to the review server.
It is available at https://review.typo3.org/26539

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.Neos has been pushed to the review server.
It is available at https://review.typo3.org/26539

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch 1.0 of project Packages/TYPO3.Neos has been pushed to the review server.
It is available at https://review.typo3.org/26540

#5 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.Neos has been pushed to the review server.
It is available at https://review.typo3.org/26539

#6 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch 1.0 of project Packages/TYPO3.Neos has been pushed to the review server.
It is available at https://review.typo3.org/26540

#7 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.Neos has been pushed to the review server.
It is available at https://review.typo3.org/26539

#8 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch 1.0 of project Packages/TYPO3.Neos has been pushed to the review server.
It is available at https://review.typo3.org/26540

#9 Updated by Christian Müller over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF