Task #54235
Epic #55070: Workpackages
Epic #54260: WP: FAL Missing Issues / Features / API
Story #54266: As an User I want FAL to be performant
getSha1 does not use the Cached property but always recalculate
| Status: | Resolved | Start date: | 2013-12-06 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assigned To: | Steffen Ritter | % Done: | 100% |
|
| Category: | File Abstraction Layer (FAL) | Spent time: | - | |
| Target version: | 6.2.0 | Estimated time: | 1.00 hour | |
| TYPO3 Version: | 6.2 | Complexity: | easy | |
| PHP Version: | Sprint Focus: |
Description
FileInterface::getSha1 - always calculates the sha1 from filesystem
Associated revisions
[TASK] Calculated hash of File object is never used
The indexing pre-calculates the file hash and stores it in
the sys_file table. Sadly the getter of file objects never looks
at this again and always recalculates the hash via the driver,
which is very slow.
Resolves: #54235
Releases: 6.2, 6.1, 6.0
Change-Id: I16bfa2126031f26b8e31da8d8c0b3fc07d0217dc
Reviewed-on: https://review.typo3.org/26689
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Oliver Klee
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
History
#1 Updated by Steffen Ritter over 1 year ago
- Parent task set to #54266
#2 Updated by Gerrit Code Review over 1 year ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26689
#3 Updated by Gerrit Code Review over 1 year ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26689
#4 Updated by Gerrit Code Review over 1 year ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26689
#5 Updated by Steffen Ritter over 1 year ago
- % Done changed from 0 to 70
#6 Updated by Gerrit Code Review over 1 year ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26689
#7 Updated by Steffen Ritter over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 70 to 100
Applied in changeset a9f111f324824dcc771cc83631a09e8b1820603b.
#8 Updated by Steffen Ritter over 1 year ago
- % Done changed from 100 to 90
#9 Updated by Steffen Ritter over 1 year ago
- % Done changed from 90 to 100