Bug #54399
Upload of non-image results in Catchable Fatal Error
| Status: | Resolved | Start date: | 2013-12-13 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | - | % Done: | 100% |
|
| Category: | - | |||
| Target version: | - |
Description
Hi!
I get a Catchable Fatal Error in Neos 1.0, when uploading a non-image file in the Media Manager (/neos/management/media). See attached file for full debug info.
#1: Catchable Fatal Error: Argument 1 passed to TYPO3\Media\ViewHelpers\ImageViewHelper_Original::render() must implement interface TYPO3\Media\Domain\Model\ImageInterface, instance of TYPO3\Media\Domain\Model\Asset given in /Volumes/Data/Users/mathias/ApacheSites/oksval2.net.local/Data/Temporary/Development/Cache/Code/Flow_Object_Classes/TYPO3_Media_ViewHelpers_ImageViewHelper.php line 104
I tested with a Word file called "test.doc". Uploading a JPEG file works fine.
- Mathias
201312131608414f8564.txt
(8.3 kB)
Associated revisions
[BUGFIX] Upload of non-image results in Catchable Fatal Error
Uploading a non-image asset into the media manager results in a fatal
error as the ImageViewHelper only processes assets implementing the
ImageInterface.
This change adds default icons for common file extensions and uses
a default fallback icon if no matching icon is found.
Change-Id: I8769987d34ac54a3d36e6d3374040438edf30612
Fixes: #54399
Fixes: #54584
Releases: master, 1.0
Reviewed-on: https://review.typo3.org/26549
Reviewed-by: Karsten Dambekalns
Tested-by: Karsten Dambekalns
[BUGFIX] Upload of non-image results in Catchable Fatal Error
Uploading a non-image asset into the media manager results in a fatal
error as the ImageViewHelper only processes assets implementing the
ImageInterface.
This change adds default icons for common file extensions and uses
a default fallback icon if no matching icon is found.
Change-Id: I8769987d34ac54a3d36e6d3374040438edf30612
Fixes: #54399
Fixes: #54584
Releases: master, 1.0
Reviewed-on: https://review.typo3.org/27467
Tested-by: Karsten Dambekalns
Reviewed-by: Carsten Bleicker
Tested-by: Carsten Bleicker
Reviewed-by: Karsten Dambekalns
History
#1 Updated by Christian Müller over 1 year ago
- Status changed from New to Accepted
We should show a placeholder for non image files in the mediabrowser.
#2 Updated by Gerrit Code Review over 1 year ago
- Status changed from Accepted to Under Review
Patch set 2 for branch master of project Packages/TYPO3.Media has been pushed to the review server.
It is available at https://review.typo3.org/26549
#3 Updated by Gerrit Code Review over 1 year ago
Patch set 3 for branch master of project Packages/TYPO3.Media has been pushed to the review server.
It is available at https://review.typo3.org/26549
#4 Updated by Gerrit Code Review over 1 year ago
Patch set 4 for branch master of project Packages/TYPO3.Media has been pushed to the review server.
It is available at https://review.typo3.org/26549
#5 Updated by Gerrit Code Review over 1 year ago
Patch set 5 for branch master of project Packages/TYPO3.Media has been pushed to the review server.
It is available at https://review.typo3.org/26549
#6 Updated by Gerrit Code Review over 1 year ago
Patch set 6 for branch master of project Packages/TYPO3.Media has been pushed to the review server.
It is available at https://review.typo3.org/26549
#7 Updated by Gerrit Code Review over 1 year ago
Patch set 7 for branch master of project Packages/TYPO3.Media has been pushed to the review server.
It is available at https://review.typo3.org/26549
#8 Updated by Gerrit Code Review over 1 year ago
Patch set 8 for branch master of project Packages/TYPO3.Media has been pushed to the review server.
It is available at https://review.typo3.org/26549
#9 Updated by Gerrit Code Review over 1 year ago
Patch set 9 for branch master of project Packages/TYPO3.Media has been pushed to the review server.
It is available at https://review.typo3.org/26549
#10 Updated by Gerrit Code Review over 1 year ago
Patch set 10 for branch master of project Packages/TYPO3.Media has been pushed to the review server.
It is available at https://review.typo3.org/26549
#11 Updated by Gerrit Code Review over 1 year ago
Patch set 11 for branch master of project Packages/TYPO3.Media has been pushed to the review server.
It is available at https://review.typo3.org/26549
#12 Updated by Gerrit Code Review over 1 year ago
Patch set 1 for branch 1.0 of project Packages/TYPO3.Media has been pushed to the review server.
It is available at https://review.typo3.org/27467
#13 Updated by Rens Admiraal over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 1c12994c2d626225d77df0ea4971e446fc8f8dc0.