Task #54944
Epic #55070: Workpackages
Epic #54260: WP: FAL Missing Issues / Features / API
Story #54272: As an Editor I expect FAL to work with the RTE
FAL links in RTE not translated when link has rel-Attribute
| Status: | Resolved | Start date: | 2014-01-13 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Stanislas Rolland | % Done: | 100% |
|
| Category: | rtehtmlarea | Spent time: | 2.00 hours | |
| Target version: | 6.2.0 | Estimated time: | 2.50 hours | |
| TYPO3 Version: | 6.1 | Complexity: | ||
| PHP Version: | 5.3 | Sprint Focus: |
Description
I have several image links (<a> Tags) in a RTE text element. These links have FAL references which look like ?file:1234. They correctly get translated to the real URL when the page is rendered.
As soon as I manually add a rel-Attribute to these links the FAL reference does no longer gets translated but stays at ?file:1234 when the page has been rendered.
This looks like a bug to me, but I'm not exactly sure if this bug is related to FAL or RTE.
The only workaround for this bug is to not use FAL links but use fixed urls instead.
Associated revisions
[BUGFIX] FAL links in RTE not transformed when link has rel attribute
Problem: When the RTE inserts the link, the href looks like
http://somedomain/?file:1234. If a rel attribute is present, the link
is not transformed into a typolink on the way to the database.
However, the href attribute is not transformed, as it should, into a
normal file url. It should because the a-tag will be rendered as is in
the frontend.
Solution: When a link is not be transformed into a typolink,
transform the href into a normal file url.
Resolves: #54944
Release: 6.2
Change-Id: I92c45363ffd62de0f4e89941944f55320d4fc708
Reviewed-on: https://review.typo3.org/27142
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Steffen Ritter
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
History
#1 Updated by Daniel Seebald over 1 year ago
Some more details on the system I'm running:
I'm using TYPO3 6.1.5 running on PHP 5.3.10.
#2 Updated by Steffen Ritter over 1 year ago
- Priority changed from Must have to Should have
- Target version set to 6.2.0
- Parent task set to #54272
#3 Updated by Stanislas Rolland over 1 year ago
- Estimated time set to 2.00
#4 Updated by Stanislas Rolland over 1 year ago
- Assigned To set to Stanislas Rolland
#5 Updated by Stanislas Rolland over 1 year ago
When the RTE inserts the link, the href looks like hhtp://somedomain/?file:1234.
If a rel attribute is present, the link is not transformed into a TYPO3 link on the way to the database. However, the href attribute is not transformed, as it should, into a normal file url. It should because the a-tag will be rendered as is in the frontend.
#6 Updated by Gerrit Code Review over 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27142
#7 Updated by Gerrit Code Review over 1 year ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27142
#8 Updated by Stanislas Rolland over 1 year ago
- % Done changed from 0 to 80
#9 Updated by Stanislas Rolland over 1 year ago
- Category changed from File Abstraction Layer (FAL) to rtehtmlarea
#10 Updated by Stanislas Rolland over 1 year ago
- Category changed from rtehtmlarea to File Abstraction Layer (FAL)
#11 Updated by Stanislas Rolland over 1 year ago
- Category changed from File Abstraction Layer (FAL) to rtehtmlarea
#12 Updated by Stanislas Rolland over 1 year ago
Daniel Seebald wrote:
As soon as I manually add a rel-Attribute to these links the FAL reference does no longer gets translated but stays at ?file:1234 when the page has been rendered.
You don't need to enter those rel attributes manually. You can configure
RTE.default.buttons.link.relAttribute.enabled = 1
in Page TSConfig. An additional field will be presented in the element browser for the rel attribute.
#13 Updated by Stanislas Rolland over 1 year ago
- Estimated time changed from 2.00 to 3.00
#14 Updated by Stanislas Rolland over 1 year ago
- Estimated time changed from 3.00 to 2.50
#15 Updated by Stanislas Rolland over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 80 to 100
Applied in changeset ba7628572ec33010e270d5738d99fbdffc17aed2.