Task #55122
Epic #55070: Workpackages
Epic #55065: WP: Overall System Performance (Backend and Frontend)
Story #55078: Optimize PHP code performance in TYPO3 methods
Cleanup and optimize methods in ExtensionManagementUtility
| Status: | Resolved | Start date: | 2014-01-18 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Michiel Roos | % Done: | 100% |
|
| Category: | Performance | Spent time: | - | |
| Target version: | 6.2.0 | |||
| TYPO3 Version: | 6.2 | Complexity: | medium | |
| PHP Version: | 5.3 | Sprint Focus: |
Description
Methods in ExtenstionManagementUtility are called a lot. We need to ensure they are as performant as possible.
- Reduce function calls
- Use language constructs instead of functions
- Use language constructs to check values before calling a function
- Return early where possible
- Rewrite addToAllTCAtypes() to just do a few preg_replace() calls and not call all the child methods
Related issues
Associated revisions
[CLEANUP] Cleanup ExtensionManagementUtility
Methods in this class are called a lot and are in need of some cleanup.- return early
- reduce method and function calls
- update doc comments
- added tests with data provider for Method getCN
Change-Id: I5dcab647fc3da078b5f29beb57fecbf7c98bcaa5
Resolves: #55122
Releases: 6.2
Reviewed-on: https://review.typo3.org/27019
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
[BUGFIX] addModule after/before not working
The cleaned up addModule() method no longer adds the module after a
module, when the target module does not exist.
Expected behaviour: module added to the list.
Observed behaviour: module not added at all.
Change-Id: Ie0d1d0c98f9c7dde81636a40eb18a3a7816392f6
Resolves: #55608
Related: #55122
Releases: 6.2
Reviewed-on: https://review.typo3.org/27284
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein
History
#1 Updated by Michiel Roos over 1 year ago
\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::executePositionedStringInsertion()
http://pastebin.com/UbMrdUL4
\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::executePositionedStringInsertion()
http://pastebin.com/UbMrdUL4
#2 Updated by Michiel Roos over 1 year ago
#3 Updated by Gerrit Code Review over 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27019
#4 Updated by Ernesto Baschny over 1 year ago
- Parent task set to #55078
#5 Updated by Gerrit Code Review over 1 year ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27019
#6 Updated by Gerrit Code Review over 1 year ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27019
#7 Updated by Gerrit Code Review over 1 year ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27019
#8 Updated by Gerrit Code Review over 1 year ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27019
#9 Updated by Gerrit Code Review over 1 year ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27019
#10 Updated by Michiel Roos over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset aa37842bd4468c9313bd98c97d6d2d76ad44e6b5.