Task #55178
Extract forward handling from errorAction
| Status: | Resolved | Start date: | 2014-01-20 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | - | % Done: | 100% |
|
| Category: | Extbase | Spent time: | - | |
| Target version: | - | |||
| TYPO3 Version: | 6.2 | Complexity: | ||
| PHP Version: | 5.3 | Sprint Focus: |
Description
The default Extbase ActionController::errorAction uses the forward method to get back to the referring request.
If a custom and different redirect shall happen here, one has to clone the whole errorAction method.
Extracting the handling simplifies customization at this state.
Related issues
Associated revisions
[TASK] Decouple responsibilities in default errorAction()
The default Extbase ActionController::errorAction does a lot
of different things, which makes it hard to customize a controller
to a desired behavior without copying all or some of its code.
Extracting the different responsibilities to separate methods
simplifies such customizations.
Resolves: #55178
Releases: master
Change-Id: I324a504c745649eec11eec65d4e6a718a5e434bd
Reviewed-on: http://review.typo3.org/26944
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
History
#1 Updated by Gerrit Code Review over 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26944
#2 Updated by Gerrit Code Review 8 months ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/26944
#3 Updated by Gerrit Code Review 8 months ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/26944
#4 Updated by Gerrit Code Review 8 months ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/26944
#5 Updated by Gerrit Code Review 8 months ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/26944
#6 Updated by Helmut Hummel 8 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 07986c435cb467c3a95a870bcecc4b35211b2589.