Bug #55369

Cookies not created if cookie lifetime is set

Added by Stephen Bungert over 1 year ago. Updated over 1 year ago.

Status:Resolved Start date:2014-01-27
Priority:Must have Due date:
Assigned To:Sebastian Heuer % Done:

100%

Category:-
Target version:-
Affected Flow version:Flow 2.0.0

Description

I have a flow based website and have increased the session timeout to 1 day. Cookies were still session only so I changed the cookie duration to one day too (I want users to be logged in even after closing the tab/browser). Whenever I do this, no cookie is created, and uses can't login.

I tried changing the value directly in typo3/flow/configuration settings, in flow/congiguration and my packages configuration. Everytime the cookie is not made. If I remove the lifetime, the cookie is created. I also tried copying the whole cookie "array" to the settings in case you have to oevrwrite all cookie values in settings. This also didn't work.

I think this is a bug. No error is shown, nothing in the server error log or the flow's system development log.

In the security log I see:

14-01-27 19:43:15 3329       127.0.0.1      NOTICE    TYPO3.Flow           Successfully authenticated token: Username: "admin" 
14-01-27 19:43:16 3329       127.0.0.1      INFO      Flow                 No account authenticated

Associated revisions

Revision 7f16897c
Added by Sebastian Heuer over 1 year ago

[BUGFIX] Set Max-Age for Cookies

If the configured session cookie lifetime is > 0, the Max-Age property of the
cookie is set accordingly in the response header.

Before this change the lifetime would be used as the expiry time, leading to
cookies having session lifetime only.

Change-Id: If293495ea325174f89d1269c1fefd2737f097924
Fixes: #55369
Releases: master, 2.0, 2.1

Revision de82f244
Added by Sebastian Heuer over 1 year ago

[BUGFIX] Set Max-Age for Cookies

If the configured session cookie lifetime is > 0, the Max-Age property of the
cookie is set accordingly in the response header.

Before this change the lifetime would be used as the expiry time, leading to
cookies having session lifetime only.

Change-Id: If293495ea325174f89d1269c1fefd2737f097924
Fixes: #55369
Releases: master, 2.0, 2.1

Revision cb283972
Added by Sebastian Heuer over 1 year ago

[BUGFIX] Set Max-Age for Cookies

If the configured session cookie lifetime is > 0, the Max-Age property of the
cookie is set accordingly in the response header.

Before this change the lifetime would be used as the expiry time, leading to
cookies having session lifetime only.

Change-Id: If293495ea325174f89d1269c1fefd2737f097924
Fixes: #55369
Releases: master, 2.0, 2.1

History

#1 Updated by Sebastian Heuer over 1 year ago

  • Status changed from New to Accepted
  • Assigned To set to Sebastian Heuer

#2 Updated by Gerrit Code Review over 1 year ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at https://review.typo3.org/27447

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at https://review.typo3.org/27447

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at https://review.typo3.org/27447

#5 Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch 2.1 of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at https://review.typo3.org/27808

#6 Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch 2.0 of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at https://review.typo3.org/27809

#7 Updated by Sebastian Heuer over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:cb283972ff79142d865a9e9cfa891038aff68254.

Also available in: Atom PDF