Task #55749
Epic #47018: Implement Composer support and clean package manager API
isPackageActive() should check runtimeActivatedPackages first
| Status: | Resolved | Start date: | 2014-02-06 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Michiel Roos | % Done: | 100% |
|
| Category: | Code Cleanup | Spent time: | - | |
| Target version: | 6.2.0 | |||
| TYPO3 Version: | 6.2 | Complexity: | no-brainer | |
| PHP Version: | 5.3 | Sprint Focus: |
Description
\TYPO3\CMS\Core\Package\PackageManager::isPackageActive() does a:
return parent::isPackageActive($packageKey) || isset($this->runtimeActivatedPackages[$packageKey]);
Where it should do a test on the more lightweight isset() first:
return isset($this->runtimeActivatedPackages[$packageKey]) || parent::isPackageActive($packageKey);
Associated revisions
[TASK] isPackageActive(): test light cond. first
The return should test for:
- isset($this->runtimeActivatedPackages[$packageKey]);
before it tests for:
- parent::isPackageActive($packageKey)
Change-Id: Ia18fb601a83e717c9bbf498eaa38c4cae04ceac6
Resolves: #55749
Releases: 6.2
Reviewed-on: https://review.typo3.org/27391
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein
History
#1 Updated by Gerrit Code Review over 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27391
#2 Updated by Ernesto Baschny over 1 year ago
- Parent task set to #47018
#3 Updated by Michiel Roos over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 5ab2885b2dc8ebeb38422bd22f50c8f1006c5319.
#4 Updated by Thomas Maroschik over 1 year ago
- Assigned To set to Michiel Roos