Bug #56902

Content cache is not domain specific

Added by Rens Admiraal over 1 year ago. Updated over 1 year ago.

Status:Resolved Start date:2014-03-14
Priority:Should have Due date:
Assigned To:- % Done:

100%

Category:-
Target version:-

Description

The content caching does not take the currently active domain into account. This means that snippets are cached containing url's in the content which could point to different url's then the user is currently visiting.

Imagine you've a setup with 2 domains pointing to 1 site node, domain1 and domain2. Whatever domain will be opened first will be in the cached snippets, and those will be served on every subsequent request no matter what domain the user is visiting.

Associated revisions

Revision 77857a6d
Added by Rens Admiraal over 1 year ago

[BUGFIX] Content cache is not domain specific

The content cache does not take the visited domain into account. This
leads to problems when multiple domains point to the same site node.
The first domain used while accessing a node will be used for generating
the cache entries, and will be served for subsequent requests even if
those originates from a different domain. This is a problem as it would
redirect the user to a different domain, and can even break AJAX
requests in the Neos backend as they will be blocked by browser policies
as being cross-domain requests.

Change-Id: I2ac3fc64af15922cbbdf1538088721bba45b0884
Releases: master, 1.1
Fixes: #56902
Reviewed-on: https://review.typo3.org/28378
Reviewed-by: Christopher Hlubek
Tested-by: Christopher Hlubek

Revision af3fb929
Added by Rens Admiraal over 1 year ago

[BUGFIX] Content cache is not domain specific

The content cache does not take the visited domain into account. This
leads to problems when multiple domains point to the same site node.
The first domain used while accessing a node will be used for generating
the cache entries, and will be served for subsequent requests even if
those originates from a different domain. This is a problem as it would
redirect the user to a different domain, and can even break AJAX
requests in the Neos backend as they will be blocked by browser policies
as being cross-domain requests.

Change-Id: I2ac3fc64af15922cbbdf1538088721bba45b0884
Releases: master, 1.1
Fixes: #56902
Reviewed-on: https://review.typo3.org/29281
Reviewed-by: Christian Mueller
Tested-by: Christian Mueller

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.Neos has been pushed to the review server.
It is available at https://review.typo3.org/28378

#2 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.Neos has been pushed to the review server.
It is available at https://review.typo3.org/28378

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.Neos has been pushed to the review server.
It is available at https://review.typo3.org/28378

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.Neos has been pushed to the review server.
It is available at https://review.typo3.org/28378

#5 Updated by Rens Admiraal over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Gerrit Code Review over 1 year ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 1.1 of project Packages/TYPO3.Neos has been pushed to the review server.
It is available at https://review.typo3.org/29281

#7 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch 1.1 of project Packages/TYPO3.Neos has been pushed to the review server.
It is available at https://review.typo3.org/29281

#8 Updated by Rens Admiraal over 1 year ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF