Bug #56924
Task #51436: Standalone unit test runner
Remove unmaintainable testclass
| Status: | Resolved | Start date: | 2014-03-14 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | - | % Done: | 100% |
|
| Category: | Unit/Functional Tests | Spent time: | - | |
| Target version: | 6.2.0 | |||
| TYPO3 Version: | 6.2 | Is Regression: | No | |
| PHP Version: | 5.4 | Sprint Focus: | ||
| Complexity: | easy |
Description
typo3/sysext/extbase/Tests/Unit/Scheduler/TaskExecutorTest.php contains only one test, but to execute this, it depends on many classes, that are not all properly mocked and therefor a nightmare to maintain. Additionally has the test nothing to do with the execution of tasks, what would be in scope of a unittest.
In order to keep the test maintenance a doable task the testclass gets removed.
Associated revisions
[TASK] Remove unmaintainable testclass
The test class contains only one test, but to execute this,
it depends on many classes which are not all properly mocked and a
nightmare to maintain. Additionally the test has nothing
to do with the execution of tasks, so subject scope is not met.
To keep test maintenance a doable task this test class in removed.
Change-Id: I97ac02040cb6dc711dcc300fb84c15c6785736e2
Resolves: #56924
Relates: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28401
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
History
#1 Updated by Gerrit Code Review over 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28401
#2 Updated by Gerrit Code Review over 1 year ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28401
#3 Updated by Gerrit Code Review over 1 year ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28401
#4 Updated by Anja Leichsenring over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset a931c8765d3877b8ad2558bba7cc8d4ed3985496.