Task #56994
Epic #55070: Workpackages
Epic #54851: WP: Workspaces IRRE & MM bugfixes
Story #54853: As a user I want to correctly create, modify, preview and publish IRRE & MM related workspace changes
Task #56376: Invalid relations of IRRE records in workspaces
Introduce shadowColumnsForMovePlaceholders property
| Status: | Resolved | Start date: | 2014-03-17 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Oliver Hader | % Done: | 100% |
|
| Category: | Workspaces | Spent time: | 1.47 hour | |
| Target version: | - | |||
| TYPO3 Version: | 6.2 | Complexity: | ||
| PHP Version: | 5.3 | Sprint Focus: |
Description
$TCA[<table>]['ctrl']['shadowColumnsForMovePlaceholders'] behaves similar to shadowColumnsForNewPlaceholders but is only used for move placeholders.
Related issues
Associated revisions
[FEATURE] Introduce shadowColumnsForMovePlaceholders property
$TCA[<table>]['ctrl']['shadowColumnsForMovePlaceholders'] behaves
similar to shadowColumnsForNewPlaceholders but is only used for
move placeholders.
If shadowColumnsForMovePlaceholders is not defined in particular
for a table, but shadowColumnsForNewPlaceholders is defined,
then that value is used as a fallback - since that property
existed for a longer time already.
Resolves: #56994
Documentation: #56749
Releases: 6.2
Change-Id: Icdbd35234efae8162cfb2dc15a2838acd22370b1
Reviewed-on: https://review.typo3.org/28473
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
History
#1 Updated by Gerrit Code Review over 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28473
#2 Updated by Thorsten Kahler over 1 year ago
- Status changed from Under Review to Needs Feedback
Why do we need another config option for move placeholders? What's the difference to new placeholders in this context?
#3 Updated by Timo Webler over 1 year ago
Available changes for move placeholder:
#4 Updated by Oliver Hader over 1 year ago
Thorsten Kahler wrote:
Why do we need another config option for move placeholders? What's the difference to new placeholders in this context?
The difference is "it is used for move placeholders" only... as written...
The reason for that is the way move-placeholders are overlaid in the frontend.
See https://review.typo3.org/#/c/27774/ and the accordant CSV tests on sorting/moving things...
#5 Updated by Oliver Hader over 1 year ago
Timo Webler wrote:
For IRRE that's not enough - the action happens in DataHandlerHook::moveRecordAvailable changes for move placeholder:
- DataHandler::versionizeRecord (creates version and the new placeholder)
- DataHanderHook::moveRecord_wsPlaceholders (creates move placeholder after everything was processed and remapped (remapStack))
- https://travis-ci.org/ohader/TYPO3.CMS/jobs/20950988 (the expected values are not set, thus misusing the newPlaceHolder property is not enough)
- https://travis-ci.org/ohader/TYPO3.CMS/jobs/20951081 (disabled the DataSet assertions - thus behaviour in frontend is not as expected)
#6 Updated by Gerrit Code Review over 1 year ago
- Status changed from Needs Feedback to Under Review
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28473
#7 Updated by Oliver Hader over 1 year ago
Gerrit Code Review wrote:
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28473
This change combines the new property for "move" with the old property for "new" as a fallback...
Thus, one can decide whether to override/disable on demand.
#8 Updated by Gerrit Code Review over 1 year ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28473
#9 Updated by Gerrit Code Review over 1 year ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28473
#10 Updated by Gerrit Code Review over 1 year ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28473
#11 Updated by Oliver Hader over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 6e9fd7da1b26e2860d4ce9ee9dd01f666d89be34.