Task #57104

Epic #55070: Workpackages

Epic #55065: WP: Overall System Performance (Backend and Frontend)

Epic #55656: Optimize overall Extbase performance

Story #55168: Optimize Extbase generic persistence

Task #55167: Extbase: avoid parseQuery() / buildQuery() to be called multiple times

Regression: Query building fails for LazyObjectStorage

Added by Alexander Stehlik over 1 year ago. Updated over 1 year ago.

Status:Resolved Start date:2014-03-20
Priority:Must have Due date:
Assigned To:- % Done:

100%
Category:Extbase Spent time: -
Target version:6.2.0
TYPO3 Version:6.2 Complexity:
PHP Version: Sprint Focus:

Description

When a LazyObjectStorage is used in an "in" comparison you get a PHP error:

Object of class TYPO3\CMS\Extbase\Persistence\Generic\LazyObjectStorage could not be converted to string in typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php line 542

I guess this is also a regression of #55167

Associated revisions

Revision ff162d36
Added by Marc Bastian Heinrichs over 1 year ago

[BUGFIX] Fix operator "in" for cached queries

This a follow up fix for the extbase query cache. On reusing an already
build query, it was missed to evaluate the multi valued operator and
provide it as array for resolving the parameter placeholders.

Resolves: #57104
Releases: 6.2
Change-Id: I06abbf5279ee05382a7ba314948f7d3f075d84e6
Reviewed-on: https://review.typo3.org/28695
Reviewed-by: Alexander Stehlik
Tested-by: Alexander Stehlik
Tested-by: Wouter Wolters
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel

History

#1 Updated by Markus Klein over 1 year ago

  • Project changed from Extbase MVC Framework to Core
  • Category deleted (Extbase: Generic Persistence)

#2 Updated by Markus Klein over 1 year ago

  • Category set to Extbase
  • Priority changed from Should have to Must have
  • Target version set to next-patchlevel
  • Is Regression set to Yes
  • TYPO3 Version set to 6.2

#3 Updated by Marc Bastian Heinrichs over 1 year ago

And what does happen, if it is a normal object storage? From reading the code it should also fail.

#4 Updated by Alexander Stehlik over 1 year ago

I think it does but I'm not sure. Started digging but did not find the right spot yet :(

#6 Updated by Alexander Stehlik over 1 year ago

Oh, than it was that spot. I have already looked at it but i was not sure.

I'll push my first WIP patch in a minute.

#7 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28576

#8 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28576

#9 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28576

#10 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28576

#11 Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28576

#12 Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28576

#13 Updated by Gerrit Code Review over 1 year ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28576

#14 Updated by Gerrit Code Review over 1 year ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28576

#15 Updated by Ernesto Baschny over 1 year ago

  • Parent task set to #55167

#16 Updated by Ernesto Baschny over 1 year ago

  • Target version changed from next-patchlevel to 6.2.0

#17 Updated by Gerrit Code Review over 1 year ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28576

#18 Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28695

#19 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28695

#20 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28695

#21 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28695

#22 Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28695

#23 Updated by Gerrit Code Review over 1 year ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28576

#24 Updated by Gerrit Code Review over 1 year ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28576

#25 Updated by Marc Bastian Heinrichs over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF