Task #57130

Epic #55070: Workpackages

Epic #55065: WP: Overall System Performance (Backend and Frontend)

Epic #55656: Optimize overall Extbase performance

Story #55168: Optimize Extbase generic persistence

Task #55167: Extbase: avoid parseQuery() / buildQuery() to be called multiple times

Extbase Queries with NULL comparison don't work anymore

Added by KJ Kooistra over 1 year ago. Updated over 1 year ago.

Status:Resolved Start date:2014-03-21
Priority:Must have Due date:
Assigned To:- % Done:

100%
Category:Extbase Spent time: -
Target version:6.2.0
TYPO3 Version:6.2 Complexity:
PHP Version: Sprint Focus:

Description

Introduced by: http://forge.typo3.org/issues/55167

See https://review.typo3.org/#/c/27555/12/typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php lines 356 - 363
Compare them to https://review.typo3.org/#/c/27555/12/typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php (removed) lines 755 - 762

The NULL operators are no longer passed on to the parseDynamicOperand method. I will add a change for this soon.

Associated revisions

Revision 8326a71f
Added by Klaas Johan Kooistra over 1 year ago

[BUGFIX] Queries with NULL don't work anymore

See change: I517c0500cad75cae96fd739f2ff7222db80b42a5
At the end of the Typo3DbQueryParser::parseComparison() method the updated
operator for NULL values was no longer passed to the parseDynamicOperand,
generating = NULL instead of IS NULL.

Solved the issue by adding the operator parameter again.

Change-Id: I13c3cecf0bf4c95789032f31ead192b945794484
Resolves: #57130
Related: #55167
Releases: 6.2
Reviewed-on: https://review.typo3.org/28592
Reviewed-by: Markus Klein
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel

Revision 449c81e4
Added by Felix Oertel over 1 year ago

[BUGFIX] FOLLOWUP Queries with NULL don't work

In https://review.typo3.org/28592 we apparently did not
fix the whole problem. This followup will deal with
the edge-case of using a similar built statement, which
results in the same hash being generated from the
QueryParser.

Resolves: #57130
Related: #55167
Releases: 6.2
Change-Id: I02a478fcabb89d11054f8f0a3c800965edfd7844
Reviewed-on: https://review.typo3.org/28715
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Markus Klein
Tested-by: Markus Klein

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28592

#2 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28592

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28592

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28592

#5 Updated by Ernesto Baschny over 1 year ago

  • Project changed from Extbase MVC Framework to Core
  • Category changed from Extbase to Extbase
  • Target version deleted (Extbase 6.2)

#6 Updated by Ernesto Baschny over 1 year ago

  • Target version set to 6.2.0
  • Complexity deleted (easy)
  • Is Regression set to No
  • TYPO3 Version set to 6.2

#7 Updated by Ernesto Baschny over 1 year ago

  • Parent task set to #55167

#8 Updated by Ernesto Baschny over 1 year ago

  • Subject changed from Queries with NULL comparison don't work anymore to Extbase Queries with NULL comparison don't work anymore

#9 Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28592

#10 Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28592

#11 Updated by Gerrit Code Review over 1 year ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28592

#12 Updated by Anonymous over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 80 to 100

#13 Updated by Gerrit Code Review over 1 year ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28715

#14 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28715

#15 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28715

#16 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28715

#17 Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28715

#18 Updated by Anonymous over 1 year ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF